Repository navigation
ci: use napi cross compile toolchain to build node native addon - #321
Merged
Merged
Conversation
Member
|
Hello @Brooooooklyn, and thank you for your contribution. Could you please expand the PR description a little, explaining why the changes are beneficial for this repo, what they do, etc. Thank you! PS: Don't mind the failing tests; in an external PR, the CI checks are using the common httpbin.org instance, which is notoriously flaky. |
Brooooooklyn
changed the title
Contributor
Author
|
@barjin done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image
ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debianis no longer maintained. The--use-napi-crossflag utilizes the same toolchain within this Docker container to compile the Node.js addon, ensuring compatibility with GLIBC 2.17.Changing this flag will speed up the CI process, as there will be no need to download the entire Docker image.