STORM-166:Nimbus HA solution based on Zookeeper #61
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| (ns backtype.storm.nimbus.leadership | ||
|
Contributor
There was a problem hiding this comment. This needs an apache license header. |
||
| (:import [backtype.storm.nimbus NimbusLeadership]) | ||
| (:use [backtype.storm log])) | ||
|
|
||
| (defn nimbus-leadership [conf] | ||
| (NimbusLeadership. conf)) | ||
|
|
||
| (defn get-nimbus-leader-address [conf] | ||
| (.getNimbusLeaderAddress (nimbus-leadership conf))) | ||
|
|
||
| (defn get-nimbus-hosts [conf] | ||
| (.getNimbusHosts (nimbus-leadership conf))) | ||
|
Contributor
There was a problem hiding this comment. We never call close on the nimbus-leadership. I believe that we are leaking a connection to ZK every time this this and get-nimbus-leader-address is called.
Author
There was a problem hiding this comment. The connection to ZK is closed when nimbus shutdown. Considering the "nimbus-leadership" function is only called in "service-handler" in nimbus.clj to acquire leadership when nimbus launching, the relative codes are placed at the end of "service-handler" as "(.close nimbus-leadership)"
Contributor
There was a problem hiding this comment. I see it now you are right. |
||
|
|
||
| (defn acquire-leadership [nimbus-leadership] | ||
| (when-let [nimbus-leader-address (.getNimbusLeaderAddress nimbus-leadership)] | ||
| (log-message "Current Nimbus Leader: " nimbus-leader-address)) | ||
| (log-message "acquiring nimbus leadership...") | ||
| (.acquireLeaderShip nimbus-leadership) | ||
| (log-message "acuqired nimbus leadership!")) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| package backtype.storm.nimbus; | ||
|
|
||
| import java.io.UnsupportedEncodingException; | ||
| import java.net.InetAddress; | ||
| import java.net.InetSocketAddress; | ||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import backtype.storm.Config; | ||
| import backtype.storm.utils.Utils; | ||
|
|
||
| import com.netflix.curator.framework.CuratorFramework; | ||
| import com.netflix.curator.framework.recipes.locks.InterProcessMutex; | ||
| import com.netflix.curator.utils.ZKPaths; | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public class NimbusLeadership { | ||
|
|
||
| private static final String STORM_NIMBUS_LEADERSHIP_PATH = "/nimbus/leadership"; | ||
|
|
||
| private Map conf; | ||
| private CuratorFramework curator; | ||
| private InterProcessMutex mutex; | ||
| private boolean isLeader = false; | ||
|
|
||
| public NimbusLeadership(final Map conf) { | ||
| this.conf = conf; | ||
| } | ||
|
|
||
| public void acquireLeaderShip() throws Exception { | ||
| String nimbusHostName = InetAddress.getLocalHost().getCanonicalHostName(); | ||
| Object nimbusPort = conf.get(Config.NIMBUS_THRIFT_PORT); | ||
| String nodeId = nimbusHostName + ":" + nimbusPort.toString(); | ||
| initCurator(); | ||
| initLeadershipMutex(nodeId); | ||
| mutex.acquire(); | ||
| isLeader = true; | ||
| } | ||
|
|
||
| public InetSocketAddress getNimbusLeaderAddress() throws Exception { | ||
| InetSocketAddress leaderAddress = null; | ||
| initCurator(); | ||
| initLeadershipMutex(null); | ||
| Collection<String> nimbusNodesPath = mutex.getParticipantNodes(); | ||
| if (nimbusNodesPath.size() > 0) { | ||
| leaderAddress = parseAddress(nimbusNodesPath.iterator().next()); | ||
| } | ||
| close(); | ||
| return leaderAddress; | ||
| } | ||
|
|
||
| public List<InetSocketAddress> getNimbusHosts() throws Exception { | ||
| List<InetSocketAddress> nimbusAddressList = new ArrayList<InetSocketAddress>(); | ||
| initCurator(); | ||
| initLeadershipMutex(null); | ||
| Collection<String> nimbusNodesPath = mutex.getParticipantNodes(); | ||
| for (String nimbusNodePath : nimbusNodesPath) { | ||
| nimbusAddressList.add(parseAddress(nimbusNodePath)); | ||
| } | ||
| close(); | ||
| return nimbusAddressList; | ||
| } | ||
|
|
||
| public void close() { | ||
|
Contributor
There was a problem hiding this comment. The spacing appears to be off here compared to the rest of the file.
Author
There was a problem hiding this comment. Invisible characters here are spaces which should be replaced by tabs. There are several pieces of codes in other files have the same problem. All will be fixed. |
||
| if (isLeader) { | ||
| try { | ||
| mutex.release(); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Exception while releasing mutex", e); | ||
| } | ||
| } | ||
| curator.close(); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private void initCurator() throws Exception { | ||
| List<String> servers = (List<String>) conf.get(Config.STORM_ZOOKEEPER_SERVERS); | ||
| Object port = conf.get(Config.STORM_ZOOKEEPER_PORT); | ||
| this.curator = Utils.newCuratorStarted(conf, servers, port); | ||
| } | ||
|
|
||
| private void initLeadershipMutex(final String nodeId) throws Exception { | ||
| String path = (String)conf.get(Config.STORM_ZOOKEEPER_ROOT) + STORM_NIMBUS_LEADERSHIP_PATH; | ||
| ZKPaths.mkdirs(curator.getZookeeperClient().getZooKeeper(), path); | ||
| mutex = new InterProcessMutex(curator, path) { | ||
| @Override | ||
| protected byte[] getLockNodeBytes() { | ||
| try { | ||
| return nodeId == null ? null : nodeId.getBytes("UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| throw new RuntimeException("UTF-8 isn't supported", e); | ||
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| private InetSocketAddress parseAddress(String nimbusNodePath) throws Exception { | ||
| String nimbusNodeData = new String(curator.getData().forPath(nimbusNodePath), "UTF-8"); | ||
| String[] split = nimbusNodeData.split(":"); | ||
| return new InetSocketAddress(split[0], Integer.parseInt(split[1])); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if nimbus.host is not used any more we should either deprecate it or just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nimbus.host relative config should be removed all over the source codes. I will fix this.