fix: show UNSPECIFIED topics on the topic list page - #709
Open
yyqdbngt wants to merge 1 commit into
Open
Conversation
Topics without a message type attribute (e.g. all normal topics on 4.x clusters, or 5.x topics created without attributes) report UNSPECIFIED. The default filter only selects NORMAL, and the UNSPECIFIED fallback was guarded by rmqVersion which is always true, so every such topic was filtered out and the topic table appeared empty. Treat UNSPECIFIED as NORMAL in the filter so the list renders again.
yyqdbngt
force-pushed
the
fix/topic-unspecified-filter
branch
from
July 31, 2026 15:33
52f4efd to
98c90a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #669
Problem
On 4.x clusters (or 5.x clusters where topics were created without a message type attribute), every topic reports
messageType = UNSPECIFIED. The topic page's default filter only selectsNORMAL, and theUNSPECIFIEDfallback branch was guarded byrmqVersionwhich is hardcoded totrueand never updated, so all these topics were filtered out and the topic table appeared empty even though the backend returned full data.Fix
In
frontend-new/src/pages/Topic/topic.jsx, treatUNSPECIFIEDas a normal topic infilterByType:Verification
npm run buildpasses on the fixed source (react-scripts build, which also runs ESLint), and the built bundle contains the updated filter logic.Diff
1 file changed, +3 / -2.