Update php client features #1256
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,6 @@ | |
| src | ||
| vendor | ||
| composer.lock | ||
| coverage | ||
| .phpunit.result.cache | ||
| phpunit.xsd | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| <?php | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace Apache\Rocketmq; | ||
|
|
||
| /** | ||
| * ClientConfiguration - Immutable configuration value object. | ||
| * Created exclusively by ClientConfigurationBuilder::build(). | ||
| * Referencing Java ClientConfiguration.java | ||
| */ | ||
| class ClientConfiguration | ||
| { | ||
| private readonly string $endpoints; | ||
| private readonly ?SessionCredentials $sessionCredentialsProvider; | ||
| private readonly int $requestTimeoutMs; | ||
| private readonly bool $sslEnabled; | ||
| private readonly string $namespace; | ||
| private readonly int $maxStartupAttempts; | ||
| private readonly ?TlsCredentials $tlsCredentials; | ||
|
|
||
| /** | ||
| * Private constructor - instantiated only via ClientConfiguration::create(). | ||
| * | ||
| * @param string $endpoints Target endpoint addresses. | ||
| * @param SessionCredentials|null $sessionCredentialsProvider Session credentials provider for authentication. | ||
| * @param int $requestTimeoutMs RPC request timeout in milliseconds. | ||
| * @param bool $sslEnabled Whether SSL is enabled. | ||
| * @param string $namespace Namespace for the client. | ||
| * @param int $maxStartupAttempts Maximum number of startup retry attempts. | ||
| * @param TlsCredentials|null $tlsCredentials TLS credentials for secure connections. | ||
| */ | ||
| private function __construct( | ||
| string $endpoints, | ||
| ?SessionCredentials $sessionCredentialsProvider, | ||
| int $requestTimeoutMs, | ||
| bool $sslEnabled, | ||
| string $namespace, | ||
| int $maxStartupAttempts, | ||
| ?TlsCredentials $tlsCredentials = null | ||
| ) { | ||
| $this->endpoints = $endpoints; | ||
| $this->sessionCredentialsProvider = $sessionCredentialsProvider; | ||
| $this->requestTimeoutMs = $requestTimeoutMs; | ||
| $this->sslEnabled = $sslEnabled; | ||
| $this->namespace = $namespace; | ||
| $this->maxStartupAttempts = $maxStartupAttempts; | ||
| $this->tlsCredentials = $tlsCredentials; | ||
| } | ||
|
|
||
| /** | ||
| * Factory method - only callable from ClientConfigurationBuilder. | ||
| * | ||
| * @param string $endpoints Target endpoint addresses. | ||
| * @param SessionCredentials|null $sessionCredentialsProvider Session credentials provider for authentication. | ||
| * @param int $requestTimeoutMs RPC request timeout in milliseconds. | ||
| * @param bool $sslEnabled Whether SSL is enabled. | ||
| * @param string $namespace Namespace for the client. | ||
| * @param int $maxStartupAttempts Maximum number of startup retry attempts. | ||
| * @param TlsCredentials|null $tlsCredentials TLS credentials for secure connections. | ||
| * @return ClientConfiguration New immutable configuration instance. | ||
| * | ||
| * @internal | ||
| */ | ||
| public static function create( | ||
| string $endpoints, | ||
| ?SessionCredentials $sessionCredentialsProvider, | ||
| int $requestTimeoutMs, | ||
| bool $sslEnabled, | ||
| string $namespace, | ||
| int $maxStartupAttempts, | ||
| ?TlsCredentials $tlsCredentials = null | ||
| ): ClientConfiguration { | ||
| return new self( | ||
| $endpoints, | ||
| $sessionCredentialsProvider, | ||
| $requestTimeoutMs, | ||
| $sslEnabled, | ||
| $namespace, | ||
| $maxStartupAttempts, | ||
| $tlsCredentials | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Get the target endpoints address. | ||
| * | ||
| * @return string Target endpoint addresses. | ||
| */ | ||
| public function getEndpoints(): string | ||
| { | ||
| return $this->endpoints; | ||
| } | ||
|
|
||
| /** | ||
| * Get the session credentials provider. | ||
| * | ||
| * @return SessionCredentials|null Session credentials provider, or null if not set. | ||
| */ | ||
| public function getSessionCredentialsProvider(): ?SessionCredentials | ||
| { | ||
| return $this->sessionCredentialsProvider; | ||
| } | ||
|
|
||
| /** | ||
| * Get the RPC request timeout in milliseconds. | ||
| * | ||
| * @return int RPC request timeout in milliseconds. | ||
| */ | ||
| public function getRequestTimeoutMs(): int | ||
| { | ||
| return $this->requestTimeoutMs; | ||
| } | ||
|
|
||
| /** | ||
| * Check whether SSL is enabled. | ||
| * | ||
| * @return bool True if SSL is enabled, false otherwise. | ||
| */ | ||
| public function isSslEnabled(): bool | ||
| { | ||
| return $this->sslEnabled; | ||
| } | ||
|
|
||
| /** | ||
| * Get the namespace. | ||
| * | ||
| * @return string Namespace for the client. | ||
| */ | ||
| public function getNamespace(): string | ||
| { | ||
| return $this->namespace; | ||
| } | ||
|
|
||
| /** | ||
| * Get the maximum number of startup retry attempts. | ||
| * | ||
| * @return int Maximum number of startup retry attempts. | ||
| */ | ||
| public function getMaxStartupAttempts(): int | ||
| { | ||
| return $this->maxStartupAttempts; | ||
| } | ||
|
|
||
| /** | ||
| * Get the TLS credentials for gRPC connections. | ||
| * | ||
| * @return TlsCredentials|null TLS credentials, or null if not set. | ||
| */ | ||
| public function getTlsCredentials(): ?TlsCredentials | ||
| { | ||
| return $this->tlsCredentials; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This named suite explicitly excludes
tests/integration, and the workflow never invokesRocketMQ PHP Integration Tests. The current telemetry timeout integration test already disagrees with the updated implementation, but CI cannot detect that regression. Please add a separate integration-test step/job (or run both suites) rather than reporting only the unit suite as the PHP build result.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed