Keep the internal CA private key across renewals with cert-manager 1.18+ - #709
Merged
Merged
Conversation
Signed-off-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708
Motivation
Since cert-manager 1.18 the default
privateKey.rotationPolicyisAlways(GA in 1.20, can no longer be turned off). The chart's self-signed CA Certificate doesn't set the field, so the CA now gets a new private key on every renewal and all previously issued certificates stop validating until each of them has been re-issued. See #708.Modifications
certs.internal_issuer.privateKeytovalues.yaml, defaulting torotationPolicy: NeverprivateKeyblock of the internal CA CertificaterotationPolicy: Neverkeeps the CA key across renewals, which was the behavior before cert-manager 1.18. Settingcerts.internal_issuer.privateKey: nullrenders the same manifest as before this change.Verifying this change