Repository navigation
Extract the consumer semaphore release sites into overridable methods - #19817
Open
deepthi912 wants to merge 1 commit into
Open
deepthi912 wants to merge 1 commit into
deepthi912 wants to merge 1 commit into
Conversation
buildSegmentInternal and downloadSegmentAndReplace each release the consumer semaphore when the parallel consumption policy allows the next segment to run during that phase. Move each guarded release into a protected method so a subclass can hold the semaphore for one phase without re-deriving the policy or distinguishing call sites itself.
deepthi912
force-pushed
the
upsert/expose-parallel-consumption-policy
branch
from
October 9, 2026 20:10
2ab7ff4 to
1db8fd9
Compare
deepthi912
changed the title
deepthi912
added
real-time
xiangfu0
approved these changes
Oct 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19817 +/- ##
============================================
- Coverage 68.63% 68.61% -0.02%
Complexity 1486 1486
============================================
Files 3526 3526
Lines 230143 230147 +4
Branches 36562 36561 -1
============================================
- Hits 157963 157925 -38
- Misses 59837 59868 +31
- Partials 12343 12354 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildSegmentInternalanddownloadSegmentAndReplaceeach release the consumer semaphore when the parallel consumption policy allows the next segment of the partition to run during that phase:This moves each guarded release into a
protectedmethod, so a subclass can hold the semaphore for one phase and leave the other alone. Today that is not expressible:closeStreamConsumerAndReleaseSemaphore()is package private and shared by both sites,_parallelSegmentConsumptionPolicyis private, and a subclass overriding the shared method cannot tell which site called it without tracking its own state.No behaviour change — the conditions and call order are unchanged.
🤖 Generated with Claude Code