Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19816 +/- ##
============================================
- Coverage 68.63% 68.56% -0.08%
Complexity 1486 1486
============================================
Files 3526 3526
Lines 230143 230151 +8
Branches 36562 36563 +1
============================================
- Hits 157963 157807 -156
- Misses 59837 60011 +174
+ Partials 12343 12333 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-stage (MSE) queries report heap allocation only per operator, inside
stageStats. The top-level*MemAllocatedBytesfields are always 0 for MSE, so users have no single number to find the queries that allocate the most memory.This PR adds
totalMemAllocatedBytesto the MSE broker response. The broker computes it from stats that already exist:allocatedMemoryBytesof each stage root. A root's value already includes the other operators of its op chain (since Account a mailbox send's current block before it reports its stats #19365).threadMemAllocatedBytesof each leaf. The single-stage threads of the leaf are not part of the stage root's value.allocatedMemoryBytesof each pipeline breaker, which runs in its own op chain.Notes:
allocatedMemoryBytesover all operators gives a number that is too large, because each value includes the children in the same stage.pinot.server.instance.enableThreadAllocatedBytesMeasurementandpinot.broker.instance.enableThreadAllocatedBytesMeasurementare enabled.