Repository navigation
Label SQL queries from the controller console - #19697
Merged
xiangfu0 merged 1 commit intoSep 29, 2026
Merged
Conversation
The query console now sends a stable applicationName with each SQL request. Explicit SQL application options still take precedence.
xiangfu0
marked this pull request as ready for review
September 28, 2026 19:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19697 +/- ##
============================================
+ Coverage 68.07% 68.08% +0.01%
Complexity 1450 1450
============================================
Files 3518 3518
Lines 228478 228478
Branches 36201 36201
============================================
+ Hits 155540 155565 +25
+ Misses 60731 60695 -36
- Partials 12207 12218 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xiangfu0
added
user-experience
yashmayya
approved these changes
Sep 28, 2026
xiangfu0
added a commit
to pinot-contrib/pinot-docs
that referenced
this pull request
Sep 29, 2026
Documents the default application name used by controller Query Console SQL requests, explicit SET precedence, and the quota rollout consideration. Follows apache/pinot#19697. Co-authored-by: Xiang Fu <xiangfu@Xiang-mac-mtv-2.local>
Contributor
Author
|
Documentation follow-up: pinot-contrib/pinot-docs#1075 (merged). This covers the Query Console application name, explicit SET precedence, and application-quota rollout consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller SQL console now sends
applicationName=pinot-controller-consoleso query logs can identify browser-console traffic.Run a query in the console and inspect
queryOptions.applicationName; an explicitSET applicationNamestill takes precedence.Validation: UI build and scoped Spotless, Checkstyle, and license checks passed. Rollout: check target cluster application quotas because labeling formerly unlabeled console traffic can cause quota rejections when a default or named quota is configured.