Repository navigation
Fix Docker broker query log appender reference - #19626
Conversation
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Could we fix this by standardizing the appender name to queryLog in both broker Log4j configs? In the Docker config, change the appender declaration to queryLog and keep the existing queryLog reference. In pinot-tools/src/main/resources/conf/pinot-broker-log4j2.xml, change both the declaration and reference. This fixes the mismatch and aligns the appender name with brokerLog and brokerHelixLog in one pass. The querylog.log filename can stay unchanged.
|
Updated in 80f7551. I standardized the appender name to
Validation completed for the root and |
80f7551 to
6703881
Compare
|
@dlscjf151 Since the file name is already |
Documents the operator-visible Docker broker query logging fix from apache/pinot#19626 in upgrade notes. Co-authored-by: Xiang Fu <xiangfu@Xiang-mac-mtv-2.local>
|
The Docker broker query logging fix is documented in the Pinot upgrade notes: pinot-contrib/pinot-docs#1070 |
Summary
Fix the Docker broker Log4j2 configuration so
QueryLoggerreferences the declaredquerylogrolling-file appender.The appender name is case-sensitive. The previous
queryLogreference did not resolve, andadditivity="false"prevented query records from falling back to the root appenders.Fixes #19625.
Testing
docker/images/pinot/etc/conf/pinot-broker-log4j2.xmlas XML.AppenderRefresolves to a declared appender../mvnw spotless:apply -N./mvnw license:format -N./mvnw checkstyle:check -N./mvnw license:check -N