Fix conflicting agent instructions and stale workflow guidance

[xiangfu0]

PR flow

Updated code review flow: delegate domain-specific skills based on diff triggers, aggregate evidence-backed findings.

flowchart TD
  N0["Invoke code#45;reviewer agent #40;F17#44; F15#44; F16#41;"]:::stModified
  N1["Resolve scope and #40;for PR#41; record SHA and inspect checks #40;F17#41;"]:::stModified
  N2["Consult code#45;review principles and conventions #40;F17#41;"]:::stModified
  N3["Select matching domains and obtain findings #40;delegate or direct#41; #40;F17#41;"]:::stModified
  N4["Aggregate findings #40;dedupe#44; resolve conflicts#44; sort#44; cap noise#41; #40;F17#41;"]:::stModified
  N5["Emit consolidated report #40;F17#41;"]:::stModified
  N0 --> N1
  N1 --> N2
  N2 --> N3
  N3 --> N4
  N4 --> N5
  classDef stAdded fill:#dafbe1,stroke:#1a7f37,color:#1f2328,stroke-width:2px
  classDef stModified fill:#fff8c5,stroke:#9a6700,color:#1f2328,stroke-width:2px
  classDef stRemoved fill:#ffebe9,stroke:#cf222e,color:#1f2328,stroke-width:2px
  classDef stUnchanged fill:#f6f8fa,stroke:#656d76,color:#1f2328,stroke-width:1px

Loading

AI-generated · Green: added · Yellow: modified · Red: removed · Gray: existing

Diff evidence

• F15: AGENTS.md — before · after
• F16: CLAUDE.md — before · after
• F17: kb/agents/code-reviewer.md — before · after

• Regenerate PR flow

Agent guidance could turn small changes into full review pipelines, repeat valid checks, stop for routine authorized work, and follow stale build or CI commands. This update scopes review and validation to the changed behavior, available evidence, and the requested task.

• Consolidate shared guidance and shorten skill descriptions; retain the plugin module reference in kb/plugin-modules.md.
• Select relevant review domains, classify findings by demonstrated impact, and use the actual pre-fix baseline for regression evidence.
• Correct feature-flag defaults, scoped Maven validation, quickstart modes and readiness checks, CI workflow queries, and benchmark dependency handling and cleanup. Preserve applicable pre-push checks while allowing bounded asynchronous work and reuse of valid results.

How to reproduce the instruction problems

• Run /precommit before pushing committed changes from a clean working tree: the previous working-tree-only default could miss the delivery diff.
• Review a multi-commit bug fix whose final commit only changes formatting: requiring failure on HEAD~1 chooses a revision that already contains the fix.
• Follow the previous flaky-test instructions: they query the removed pinot_tests.yml workflow instead of the current unit/integration workflows.

Validation

• git diff --check passed.
• Checked 35 Markdown files, 57 local links, 14 YAML frontmatter blocks, settings JSON, and preservation of all 167 principle IDs; all passed. Five operational skill entry points passed the skill validator.
• ./mvnw -N license:format license:check passed with JDK 25: 46 files checked and no headers changed.
• Commands, quickstart modes, workflow paths, and compiler properties checked against the current POMs, local plugin metadata, and relevant source.
• Documentation only. Java formatting, Checkstyle, compilation, and runtime tests are not applicable to this diff.