Skip to content

Make Command execute method generic - #1368

Open
25girhese-rbu wants to merge 1 commit into
apache:masterfrom
25girhese-rbu:master
Open

Make Command execute method generic#1368
25girhese-rbu wants to merge 1 commit into
apache:masterfrom
25girhese-rbu:master

Conversation

@25girhese-rbu

@25girhese-rbu 25girhese-rbu commented Mar 31, 2026

Copy link
Copy Markdown

Introduce a generic execute signature () on Command and parameterize AbstractCommand with T to allow commands to return specific ScmResult subtypes. Update AbstractCheckOutCommand to extend AbstractCommand and adjust its execute/executeCommand signatures accordingly. Adapt GitCheckOutCommand to the new checkout API: use the new executeCheckOutCommand params, rename repository to gitRepo, remove legacy binary/forceBinary handling, add recursive clone flag, and update clone/pull/checkout/list command invocations. Add success_build.log and apply minor comment/formatting tweaks.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Introduce a generic execute signature (<T extends ScmResult>) on Command and parameterize AbstractCommand with T to allow commands to return specific ScmResult subtypes. Update AbstractCheckOutCommand to extend AbstractCommand<CheckOutScmResult> and adjust its execute/executeCommand signatures accordingly. Adapt GitCheckOutCommand to the new checkout API: use the new executeCheckOutCommand params, rename repository to gitRepo, remove legacy binary/forceBinary handling, add recursive clone flag, and update clone/pull/checkout/list command invocations. Add success_build.log and apply minor comment/formatting tweaks.
@kwin

kwin commented May 18, 2026

Copy link
Copy Markdown
Member

Isn’t this covered in #1273?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants