Custom GradleWrapper - #16483
Draft
dsmiley wants to merge 2 commits into
Draft
Conversation
dsmiley
commented
Aug 4, 2026
dsmiley
left a comment
dsmiley
left a comment
Contributor
Author
There was a problem hiding this comment.
There's probably no more code involved in doing this than what we have tody. I like that it's simpler; removing some entanglements in the shell & GHA yml.
Execute gradle in the same JVM. Support the gradle-wrapper.jar if present. Only include basic/used gradle-wrapper.properties
dweiss
reviewed
Aug 6, 2026
dweiss
left a comment
dweiss
left a comment
Contributor
There was a problem hiding this comment.
I like the idea. I'm not sure what the original gradle wrapper does (or will do in the future) though - it'd be good to move the burden of maintaining it to gradle itself... but I don't have high hopes they'll be interested.
What was the source of your frustration with the previous downloader? It didn't work? I never had any problem with it, even when switching branches etc.
Comment on lines
+98
to
+99
| @rem No staleness check: if you edit GradleWrapper.java, delete %GRADLE_WRAPPER_CACHE% to force | ||
| @rem a recompile (this file changes rarely, so keeping this simple is worth that manual step). |
Contributor
There was a problem hiding this comment.
It's going to be trouble on Windows if the wrapper is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got frustrated with the gradle wrapper situation. The fact that we went through all this trouble here with a custom downloader -- all to download another tiny program (the actual gradle wrapper) to basically just download and run Gradle ... seems a bit silly, no?
So I had an idea and filed it with the Gradle project to offer the wrapper in source form.. Maybe they won't implement the idea but nonetheless we are certainly empowered to do so. It's not hard!