Fix over-allocation of result bitset in MemoryAccountingBitsetCollectorManager - #16452
Open
Sasilekha wants to merge 1 commit into
Open
Fix over-allocation of result bitset in MemoryAccountingBitsetCollectorManager#16452Sasilekha wants to merge 1 commit into
Sasilekha wants to merge 1 commit into
Conversation
Sasilekha
force-pushed
the
tighten-memory-accounting-bitset-result-size
branch
from
August 1, 2026 12:33
d6ab44f to
755683b
Compare
Sasilekha
marked this pull request as ready for review
August 2, 2026 07:29
…orManager Size the reduce() result FixedBitSet to the highest matched doc + 1 instead of the largest maxDocEnd across collectors. The old sizing was inflated to the last visited leaf's docBase+maxDoc even when the query matched only a small subset, and under intra-segment concurrency it could equal the full index maxDoc.
Sasilekha
force-pushed
the
tighten-memory-accounting-bitset-result-size
branch
from
August 4, 2026 14:17
755683b to
837c512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size the reduce() result FixedBitSet to the highest matched doc + 1 instead of the largest maxDocEnd across collectors. The old sizing was inflated to the last visited leaf's docBase+maxDoc even when the query matched only a small subset, and under intra-segment concurrency it could equal the full index maxDoc.