Conversation
`KubernetesExtensions.getApplicationReport` failed to compile under Scala 2.13 (the default build): `client.pods...list.getItems.asScala` returns `scala.collection.mutable.Buffer`, but the enclosing `val executors: Seq[Pod]` requires `scala.collection.immutable.Seq` (the 2.13 default for the unqualified `Seq` alias). Scala 2.12 allowed the implicit widening; 2.13 does not. Adds `.toSeq`, matching the same conversion already used a few lines above for the driver-pod lookup. `mvn install -pl core/scala-2.13,server -am -DskipTests` failed with this exact type-mismatch error before the fix and succeeds after it. Generated-by: Claude Code (Sonnet 5)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
=============================================
- Coverage 68.68% 53.72% -14.97%
+ Complexity 1218 847 -371
=============================================
Files 106 106
Lines 6815 6870 +55
Branches 836 846 +10
=============================================
- Hits 4681 3691 -990
- Misses 1666 2738 +1072
+ Partials 468 441 -27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@soumyadeeplogin @roczei This is a small follow up fix to LIVY-1072 to make the change compatible with Scala 2.13 (the PR had been merged before the Spark 4 update went in adding Scala 2.13 tests, so the build issue was not discovered). |
Contributor
|
I tested it and it resolved the compilation error. Thanks for the fix! |
roczei
approved these changes
Sep 15, 2026
Contributor
|
LGTM, thanks for catching this @gyogal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
KubernetesExtensions.getApplicationReportfailed to compile under Scala 2.13 (the default build):client.pods...list.getItems.asScalareturnsscala.collection.mutable.Buffer, but the enclosingval executors: Seq[Pod]requiresscala.collection.immutable.Seq(the 2.13 default for the unqualifiedSeqalias). Scala 2.12 allowed the implicit widening; 2.13 does not.Adds
.toSeq, matching the same conversion already used a few lines above for the driver-pod lookup.How was this patch tested?
mvn install -pl core/scala-2.13,server -am -DskipTestsfailed with this exact type-mismatch error before the fix and succeeds after it.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Sonnet 5)