HBASE-30275 TestRecoveryPersistentBucketCache#testBucketCacheRecovery…

[mnpoonia]

…WithAllocationInconsistencies has a race condition between backingMapValidated and cacheState=ENABLED

[wchevreuil]

Thanks for submitting this fix.

Just a nit comment: should we set pollDelay and pollInterval to 10ms? IIUC, Awaitility sets these to 100ms, by default.

[mnpoonia]

Thanks @wchevreuil. i was thinking the same but then i thought how much difference will pollinterval of 10 ms and 100 ms would make.

But Now i see that adding it will make sure test behaviour would be same as before. I will add it.

[mnpoonia]

@wchevreuil Added the pollDelay and pollInterval of 10ms. Please review.

[guluo2016]

For me is ok.
A small nit: pollDelay would be autimatically set as to the same value as pollInterval.
Since both are set to 10ms here, maybe the pollDelay(Duration.ofMillis(10))can be removed.

[mnpoonia]

You're right — Awaitility's pollDelay defaults to the same value as pollInterval when not explicitly set. So we could have written just:

await().atMost(Duration.ofSeconds(30))
.pollInterval(Duration.ofMillis(10)).until(...)

and it would have the same behavior (10ms initial delay, 10ms between polls). Setting both explicitly just makes the intent clearer. What do you think.
If you want it concise, we can remove pollDelay

[guluo2016]

Setting both explicitly just makes the intent clearer

Agreed，thanks