Skip to content

[#12145] fix(test): prevent overlapping embedded server lifecycle on branch-1.3 - #13008

Merged
yuqi1129 merged 1 commit into
apache:branch-1.3from
yuqi1129:fix-12145-minigravitino-branch-1.3
Sep 9, 2026
Merged

[#12145] fix(test): prevent overlapping embedded server lifecycle on branch-1.3#13008
yuqi1129 merged 1 commit into
apache:branch-1.3from
yuqi1129:fix-12145-minigravitino-branch-1.3

Conversation

@yuqi1129

@yuqi1129 yuqi1129 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Backport #12146 to branch-1.3. Wait for the MiniGravitino server task to terminate before returning from stop(), and clean up resources even if shutdown fails. Add a regression test that delays server cleanup and verifies that stop() waits for it.

Why are the changes needed?

The HTTP port can close before the shared GravitinoEnv finishes shutting down. Starting the next embedded server during that window lets the previous shutdown close its catalog manager. This caused CatalogPaimonJdbcCredentialIT initialization to fail with CatalogManager is already closed on branch-1.3.

CI failure: https://github.com/apache/gravitino/actions/runs/34222422837/job/102048711221

Fix: #12145

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • ./gradlew :integration-test-common:test --tests org.apache.gravitino.integration.test.TestMiniGravitino -PskipITs — 3 tests passed.
  • ./gradlew spotlessApply :integration-test-common:check -PskipITs — 9 tests passed.
  • git diff HEAD --check

Copilot AI lite review requested due to automatic review settings September 8, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Code Coverage Report

Overall Project 69.27% 🟢
Files changed No Java source files changed -

Module Coverage
aliyun 19.74% 🔴
api 47.62% 🟢
authorization-common 85.96% 🟢
aws 53.54% 🟢
azure 32.1% 🔴
catalog-common 10.4% 🔴
catalog-fileset 80.51% 🟢
catalog-glue 69.24% 🟢
catalog-hive 79.42% 🟢
catalog-jdbc-clickhouse 84.7% 🟢
catalog-jdbc-common 44.88% 🟢
catalog-jdbc-doris 82.61% 🟢
catalog-jdbc-hologres 54.03% 🟢
catalog-jdbc-mysql 79.33% 🟢
catalog-jdbc-oceanbase 78.6% 🟢
catalog-jdbc-postgresql 83.83% 🟢
catalog-jdbc-starrocks 79.16% 🟢
catalog-kafka 77.27% 🟢
catalog-lakehouse-generic 59.7% 🟢
catalog-lakehouse-hudi 79.1% 🟢
catalog-lakehouse-iceberg 85.9% 🟢
catalog-lakehouse-paimon 82.17% 🟢
catalog-model 77.99% 🟢
cli 44.51% 🟢
client-java 78.31% 🟢
common 50.74% 🟢
core 83.24% 🟢
filesystem-hadoop3 77.3% 🟢
flink 0.0% 🔴
flink-common 50.39% 🟢
flink-runtime 0.0% 🔴
gcp 32.2% 🔴
hadoop-common 15.43% 🔴
hive-metastore-common 53.86% 🟢
iceberg-aliyun-bundle 0.0% 🔴
iceberg-common 60.29% 🟢
iceberg-rest-server 74.5% 🟢
idp-basic 86.76% 🟢
integration-test-common 0.0% 🔴
jobs 66.17% 🟢
lance-common 24.42% 🔴
lance-rest-server 60.32% 🟢
lineage 59.39% 🟢
optimizer 82.95% 🟢
optimizer-api 21.95% 🔴
server 89.03% 🟢
server-common 77.1% 🟢
spark 28.57% 🔴
spark-common 45.69% 🟢
trino-connector 58.22% 🟢

@yuqi1129
yuqi1129 merged commit 50d83f1 into apache:branch-1.3 Sep 9, 2026
35 checks passed
@yuqi1129
yuqi1129 deleted the fix-12145-minigravitino-branch-1.3 branch September 9, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants