[#12982] fix(core): mask undeclared credential-like properties by name - #12983
Open
lasdf1234 wants to merge 8 commits into
Open
[#12982] fix(core): mask undeclared credential-like properties by name#12983lasdf1234 wants to merge 8 commits into
lasdf1234 wants to merge 8 commits into
Conversation
…by name Mask API responses for property keys matching secret/password/token/ credential/access, and return stored plaintext for those keys from getSecrets so clients that merge properties() + getSecrets() still work. Co-authored-by: Cursor <cursoragent@cursor.com>
…buildSecrets buildSecrets only reads raw stored properties, which already reject ******. Co-authored-by: Cursor <cursoragent@cursor.com>
Cover azure-storage-account-key/name and gcs-service-account-file via the same name-based mask and getSecrets plaintext path. Co-authored-by: Cursor <cursoragent@cursor.com>
…c tables Keep name-based property masking for tables; recover plaintext via SupportsSecrets so Flink JDBC generic tables do not connect with ******. Co-authored-by: Cursor <cursoragent@cursor.com>
…ersion Name-masked sensitive properties need plaintext recovery via SupportsSecrets for every entity type that applies name-based masking, including MODEL_VERSION. Co-authored-by: Cursor <cursoragent@cursor.com>
Name-masked catalog/schema properties() return ******, while Lance describeNamespace merges getSecrets() plaintext for storage options. Co-authored-by: Cursor <cursoragent@cursor.com>
ModelVersion is a storage entity, not a MetadataObject; secrets/tags/roles APIs hang on MODEL. Keep name-masking but drop MODEL_VERSION object wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
secret,password,token,credential, oraccess, case-insensitive;_/-equivalent) as sensitive even when undeclared in properties metadata******on API read paths viaHiddenPropertyMaskUtilsgetSecrets/SecretPropertyUtils.buildSecrets(in addition to existing secret-manager URN resolution), so clients that mergeproperties()+getSecrets()(Spark/Flink/IRC standalone) still receive usable credentialsWhy are the changes needed?
Redaction previously depended only on declared
hiddenmetadata. A mistyped credential property name bypassed masking and leaked plaintext on catalog get/list.Fix: #12982
Does this PR introduce any user-facing change?
Yes.
******instead of plaintext.getSecretsmay include additional keys: sensitive-named inline plaintext values, not only secret-manager URN resolutions.How was this patch tested?