-
Notifications
You must be signed in to change notification settings - Fork 935
[#12953] feat(mcp-server): select the metalake per tool call #12960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5cdb09b
[#12953] feat(mcp-server): resolve metalake per HTTP request instead …
jerryshao de37249
docs(mcp-server): shorten --metalake table cell to fix table rendering
jerryshao f4e463d
[#12953] fix(mcp-server): address review feedback on per-request meta…
jerryshao e5e023f
docs(mcp-server): state plainly when --metalake is required
jerryshao 67773f0
[#12953] feat(mcp-server): select the metalake per tool call
jerryshao a851184
[#12953] fix(mcp-server): address review of per-call metalake selection
jerryshao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from abc import ABC, abstractmethod | ||
|
|
||
|
|
||
| class MetalakeOperation(ABC): | ||
| """ | ||
| Abstract base class for Gravitino metalake operations. | ||
|
|
||
| Unlike every other operation, these are not scoped to a single metalake: | ||
| they address the server's top-level ``/api/metalakes`` endpoint, so an | ||
| agent can discover which metalakes it may operate on before naming one. | ||
| """ | ||
|
|
||
| @abstractmethod | ||
| async def get_list_of_metalakes(self) -> str: | ||
| """ | ||
| Retrieve the list of metalakes the caller is allowed to see. | ||
|
|
||
| Returns: | ||
| str: JSON-formatted string containing metalake information. | ||
| """ | ||
| pass |
36 changes: 36 additions & 0 deletions
36
mcp-server/mcp_server/client/plain/plain_rest_client_metalake_operation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from httpx import AsyncClient | ||
|
|
||
| from mcp_server.client.metalake_operation import MetalakeOperation | ||
| from mcp_server.client.plain.utils import extract_content_from_response | ||
|
|
||
|
|
||
| class PlainRESTClientMetalakeOperation(MetalakeOperation): | ||
| """Metalake operations against the server's top-level endpoint. | ||
|
|
||
| Takes no metalake name: this is the one operation that must work before a | ||
| metalake has been chosen. | ||
| """ | ||
|
|
||
| def __init__(self, rest_client: AsyncClient): | ||
| self.rest_client = rest_client | ||
|
|
||
| async def get_list_of_metalakes(self) -> str: | ||
| response = await self.rest_client.get("/api/metalakes") | ||
| return extract_content_from_response(response, "metalakes", []) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.