[#12947] fix(catalog): reject unknown catalog properties to prevent credential leaks - #12948
Open
lasdf1234 wants to merge 2 commits into
Open
[#12947] fix(catalog): reject unknown catalog properties to prevent credential leaks#12948lasdf1234 wants to merge 2 commits into
lasdf1234 wants to merge 2 commits into
Conversation
…vent credential leaks Mistyped credential keys were accepted as undeclared catalog properties and returned unredacted. Reject unknown catalog keys on create/alter upsert while keeping bypass prefixes and allowing cleanup deletes. Co-authored-by: Cursor <cursoragent@cursor.com>
…r closed set Declare fs.path.config.* so location-scoped fileset catalog configs are not rejected. Also null-guard alter validation and clarify unknown-property errors. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PropertiesMetadata.rejectsUnknownProperties()).gravitino.bypass.,trino.bypass.,flink.bypass.,spark.bypass..fs.path.config.prefix so location-scoped catalog configs remain valid.s3-*, fileset unknown-property rejection, andfs.path.config.*.Table/schema/other open property models are unchanged.
Raw Hadoop filesystem keys that are neither declared nor under
gravitino.bypass.are now rejected on catalog create/alter; pass them with thegravitino.bypass.prefix.Why are the changes needed?
Undeclared catalog properties skip hidden-property redaction, so a mistyped credential property name becomes a plaintext disclosure on read/list paths.
Fix: #12947
Does this PR introduce any user-facing change?
Yes. Catalog create/alter now rejects property keys that are not declared by the provider (except declared prefixes such as
gravitino.bypass.*and filesetfs.path.config.*). Previously unknown keys were accepted.How was this patch tested?
TestPropertiesMetadataHelpersTestGlueCatalogPropertiesMetadataTestFilesetCloudPropertiesMetadata