[rust] Preserve highest_field_id during Schema JSON deserialization - #4184
Merged
fresh-borzoni merged 2 commits intoSep 1, 2026
Merged
Conversation
fresh-borzoni
approved these changes
Sep 1, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@beryllw Thank you for the PR, LGTM, minor non-blocking comments
Nice catch. Java doesn't have this check: SchemaJsonSerde takes whatever's in the JSON, so we'd reject metadata the Java client reads. Probably unreachable, but was rejecting deliberate over clamping to max()?
The !columns_with_ids.is_empty() guard leaves a hole: {"columns": [],"highest_field_id": -3} deserializes fine and keeps -3, below the -1 default.
schema_nested_row_round_trips_through_json uses highest == max, so it wouldn't have caught this.
fresh-borzoni
approved these changes
Sep 1, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@beryllw Thank you, LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4181
Brief change log
Tests
API and Format
Documentation