Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions fluss-rust/crates/fluss/src/metadata/table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,19 @@ impl SchemaBuilder {
return Ok(columns.to_vec());
};

if pk.column_names.is_empty() {
return Err(Error::invalid_table(
"Primary key constraint must be defined for at least a single column.",
));
}

let primary_key_names: Vec<_> = pk.column_names.iter().collect();
if let Some(duplicates) = Self::find_duplicates(&primary_key_names) {
return Err(Error::invalid_table(format!(
"Primary key constraint must not contain duplicate columns. Found: {duplicates:?}"
)));
}

let pk_set: HashSet<_> = pk.column_names.iter().collect();
let all_columns: HashSet<_> = columns.iter().map(|c| &c.name).collect();
if !pk_set.is_subset(&all_columns) {
Expand Down Expand Up @@ -1652,6 +1665,31 @@ mod tests {
use super::*;
use crate::metadata::DataTypes;

#[test]
fn invalid_primary_keys_are_rejected() {
for (primary_keys, expected_message) in [
(
Vec::<&str>::new(),
"Primary key constraint must be defined for at least a single column.",
),
(
vec!["id", "id"],
"Primary key constraint must not contain duplicate columns.",
),
] {
let err = Schema::builder()
.column("id", DataTypes::int())
.primary_key(primary_keys)
.build()
.unwrap_err();

assert!(
err.to_string().contains(expected_message),
"unexpected error: {err}"
);
}
}

#[test]
fn auto_increment_column_requires_a_primary_key_table() {
let err = Schema::builder()
Expand Down
Loading