Skip to content

build(deps): Upgrade to latest SpotBugs #19576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amaechler wants to merge 4 commits into
base: master
Choose a base branch
from
Open

build(deps): Upgrade to latest SpotBugs #19576

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1544c38
Upgrade SpotBugs to 4.10.2
amaechler Jun 23, 2026
10c4faa
Exclude detector patterns new in SpotBugs 4.9 and 4.10
amaechler Jun 23, 2026
62a4abc
Remove suppressions SpotBugs reports as useless
amaechler Jun 23, 2026
9ed1ca7
Merge branch 'master' into spotbugs-upgrade
amaechler Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions codestyle/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,28 @@
<Class name="org.apache.druid.msq.indexing.MSQWorkerTaskLauncher" />
</And>
</Match>
<Match>
<!-- unzip() drains and discards the rest of the stream (workaround for #6905); the read buffer is intentionally unused -->
<And>
<Bug pattern="NCR_NOT_PROPERLY_CHECKED_READ" />
<Class name="org.apache.druid.utils.CompressionUtils" />
</And>
</Match>
<Match>
<!-- notifyAll() wakes waiters after state is mutated under the same lock, either in the caller or via @GuardedBy concurrent structures -->
<And>
<Bug pattern="NN_NAKED_NOTIFY" />
<Or>
<Class name="org.apache.druid.indexing.overlord.hrtr.HttpRemoteTaskRunner" />
<Class name="org.apache.druid.metadata.segment.cache.HeapMemorySegmentMetadataCache" />
</Or>
</And>
</Match>

<Bug pattern="AT_NONATOMIC_64BIT_PRIMITIVE"/>
<Bug pattern="AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE"/>
<Bug pattern="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION"/>
<Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
<Bug pattern="BC_UNCONFIRMED_CAST"/>
<Bug pattern="BIT_SIGNED_CHECK_HIGH_BIT"/>
<Bug pattern="BX_UNBOXING_IMMEDIATELY_REBOXED"/>
Expand All @@ -100,6 +120,7 @@
<Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ"/>
<Bug pattern="FE_FLOATING_POINT_EQUALITY"/>
<Bug pattern="HE_EQUALS_USE_HASHCODE"/>
<Bug pattern="HSM_HIDING_METHOD"/>
<Bug pattern="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD"/>
<Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE"/>
<Bug pattern="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL"/>
Expand Down Expand Up @@ -137,6 +158,10 @@
<Bug pattern="SWL_SLEEP_WITH_LOCK_HELD"/>
<Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH"/>
<Bug pattern="URF_UNREAD_FIELD"/>
<Bug pattern="USO_UNSAFE_ACCESSIBLE_OBJECT_SYNCHRONIZATION"/>
<Bug pattern="USO_UNSAFE_EXPOSED_OBJECT_SYNCHRONIZATION"/>
<Bug pattern="USO_UNSAFE_METHOD_SYNCHRONIZATION"/>
<Bug pattern="USO_UNSAFE_OBJECT_SYNCHRONIZATION"/>
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
<Bug pattern="SING_SINGLETON_INDIRECTLY_IMPLEMENTS_CLONEABLE"/>
Expand Down
10 changes: 1 addition & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,15 +1722,7 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.9.3.2</version>
<dependencies>
<!-- overwrite dependency on spotbugs if you want to specify the version of spotbugs -->
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>4.8.6</version>
</dependency>
</dependencies>
<version>4.10.2.0</version>
<configuration>
<excludeFilterFile>codestyle/spotbugs-exclude.xml</excludeFilterFile>
<maxHeap>768</maxHeap>
Expand Down
1 change: 0 additions & 1 deletion processing/src/main/java/org/apache/druid/math/expr/Function.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2172,7 +2172,6 @@ public String name()
return "case_searched";
}

@SuppressFBWarnings("IM_BAD_CHECK_FOR_ODD")
@Override
public ExprEval apply(final List<Expr> args, final Expr.ObjectBinding bindings)
{
Expand Down
1 change: 0 additions & 1 deletion processing/src/main/java/org/apache/druid/segment/index/IndexedUtf8ValueIndexes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ public BitmapColumnIndex forSortedValues(SortedSet<String> values)
);
}

@SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION")
@Override
public BitmapColumnIndex forSortedValuesUtf8(List<ByteBuffer> sortedValuesUtf8)
{
Expand Down
Loading