Allow Range partitioned inputs to PartitionedTopK#23355
Open
stuhood wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
physical-expr
stuhood
changed the title
stuhood
force-pushed
the
stuhood.range-partitioned-top-k
branch
from
1b1c490 to
e236f7b
Compare
stuhood
force-pushed
the
stuhood.range-partitioned-top-k
branch
3 times, most recently
from
eb2c841 to
3ab476d
Compare
Contributor
|
This is in my queue, just waiting for #23184 to land 🙇 |
stuhood
force-pushed
the
stuhood.range-partitioned-top-k
branch
from
3ab476d to
7d0f380
Compare
github-actions
Bot
removed
physical-expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partitioning::Rangeto satisfy PartitionedTopKDistribution::KeyPartitionedrequirements #23290.What changes are included in this PR?
In two commits:
WindowTopNto intermediateRepartitionExecnodes, to ensure thatPartitionedTopKcan still be used whentarget_partitionsmismatches physical partitions.required_input_distributionsto declare required partitioning forPartitionedTopKExec,BoundedWindowAggExec, andWindowAggExec.Are these changes tested?
Yes, new
slttests are added for both theWindowTopNrobustness fix, and for the use ofrequired_input_distributionsinPartitionedTopK.Are there any user-facing changes?
No: only plan changes.