Keep HashCodeBuilder.append(Object) from poisoning reflection hashCode#1747
Merged
garydgregory merged 1 commit intoJul 11, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
new HashCodeBuilder(17, 37).append((Object) x).toHashCode()wherex.hashCode()isHashCodeBuilder.reflectionHashCode(x)returns17 * 37 + 17instead of17 * 37 + x.hashCode(). The same collapse hits an ordinary acyclic graph:reflectionHashCode(holder)drops the content of any field whose ownhashCode()is reflection based, so two holders differing only in such a field share a hash whilereflectionEqualsreports them unequal.Cause: the cycle guard added in #1650 has
append(Object)callregister(object)on the sameREGISTRYthatreflectionAppendconsults, sox's reflectivehashCode()findsxalready registered, mistakes it for a cycle and returns the bare initial value.Fix:
append(Object)keeps a separate append registry for its re-entrancy guard and still checksREGISTRY, so reflection cycles (including the mutually referentialtestReflectionObjectCycle) behave exactly as before.Added
testAppendObjectReflectionHashCodeNotPoisoned; it fails before (expected1300, was646) and passes after.