Fix packed stream count check in SevenZFile.sanityCheckUnpackInfo - #791
Merged
Merged
Conversation
folders consuming more packed streams than kPackInfo declares slipped past the comparison and overran packStreamOffsets in reopenFolderInputStream.
garydgregory
added a commit
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanityCheckUnpackInfo compares packedStreamsRequiredByFolders with numberOfPackedStreams the wrong way round, so the case its own error message names, folders needing more packed streams than kPackInfo declares, is the one that gets through. calculateStreamMap then walks folderFirstPackStreamIndex past the end of packStreamOffsets, and the first entry of the second folder of an archive declaring a single packed stream makes getNextEntry throw ArrayIndexOutOfBoundsException out of reopenFolderInputStream instead of the declared IOException; buildDecoderStack indexes packSizes with the same value. requiring the two counts to be equal keeps every archive the old comparison accepted, since it already rejected the opposite direction. the fuzz input behind the build-excluded SevenZReadSubStreamsInfoTest declares no packed streams for its single folder, so it now stops here rather than in the substream allocation.
mvn; that'smvnon the command line by itself.