ATLAS-5322: Fix glossary bulk import relation parsing and error reporting. #712
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { | ||
| buildGlossaryImportFailureSummary, | ||
| formatGlossaryImportFailure | ||
| } from "../glossaryImportUtils"; | ||
|
|
||
| describe("glossaryImportUtils", () => { | ||
| it("formats failure with glossary term label", () => { | ||
| expect( | ||
| formatGlossaryImportFailure({ | ||
| childObjectName: "Patient", | ||
| parentObjectName: "Healthcare Glossary", | ||
| remarks: "Reference not found" | ||
| }) | ||
| ).toBe("Patient@Healthcare Glossary: Reference not found"); | ||
| }); | ||
|
|
||
| it("builds import summary with success and failure counts", () => { | ||
| expect( | ||
| buildGlossaryImportFailureSummary({ | ||
| successImportInfoList: [{ childObjectName: "A" }], | ||
| failedImportInfoList: [ | ||
| { | ||
| childObjectName: "Patient", | ||
| parentObjectName: "Healthcare Glossary", | ||
| remarks: "Invalid relation" | ||
| } | ||
| ] | ||
| }) | ||
| ).toBe( | ||
| "Glossary import completed with 1 failure(s) out of 2 term(s). See error details." | ||
| ); | ||
| }); | ||
| }); | ||
|
Contributor
There was a problem hiding this comment. Missing negative / edge cases: Only remarks (no names) suggestion: |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| export interface GlossaryImportFailure { | ||
| childObjectName?: string; | ||
| parentObjectName?: string; | ||
| remarks?: string; | ||
| rowNumber?: number; | ||
| } | ||
|
|
||
| export interface GlossaryImportResponse { | ||
| failedImportInfoList?: GlossaryImportFailure[]; | ||
| successImportInfoList?: GlossaryImportFailure[]; | ||
| } | ||
|
|
||
| export const formatGlossaryImportFailure = ( | ||
| failure: GlossaryImportFailure | ||
| ): string => { | ||
| const termLabel = | ||
|
Contributor
There was a problem hiding this comment. Requires both childObjectName and parentObjectName for @ format -add test for childObjectName-only case (same-glossary shorthand failures from backend) |
||
| failure.childObjectName && failure.parentObjectName | ||
| ? `${failure.childObjectName}@${failure.parentObjectName}` | ||
| : failure.childObjectName || "Unknown term"; | ||
|
|
||
| return `${termLabel}: ${failure.remarks || "Import failed"}`; | ||
| }; | ||
|
|
||
| export const buildGlossaryImportFailureSummary = ( | ||
| response: GlossaryImportResponse | ||
| ): string => { | ||
| const failedCount = response.failedImportInfoList?.length || 0; | ||
| const successCount = response.successImportInfoList?.length || 0; | ||
| const totalCount = failedCount + successCount; | ||
|
|
||
| return `Glossary import completed with ${failedCount} failure(s) out of ${totalCount} term(s). See error details.`; | ||
|
Contributor
There was a problem hiding this comment. Summary string is hardcoded glossary-specific ("Glossary import completed...")
|
||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical issue Blovker: — Business Metadata regression:
ImportDialog serves both glossary and business metadata (title == "Import Business Metadata"). The PR applies glossary-specific formatting to the shared failure block:
-And error details use formatGlossaryImportFailure(), which assumes glossary semantics (child@parent). For business metadata, backend stores fields differently (parentObjectName = guid, childObjectName = attributes), producing misleading labels like attributes@guid: error.
solution:
ImportDialog is shared between glossary and business metadata imports. Please guard glossary-specific formatting:
Same guard needed in the error details list (line 207–218).