introduce append_array() - #10765
Open
Rich-T-kid wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
arrow
Contributor
Author
|
run benchmark cast_kernels env: |
Rich-T-kid
force-pushed
the
rich-T-kid/bench-dict-append-array-impl
branch
from
August 19, 2026 20:58
14e35c9 to
33cded2
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels env: |
|
Hi @Rich-T-kid, your benchmark configuration could not be parsed (#10765 (comment)). Error: Usage: Any benchmark name is accepted: Per-side configuration ( env:
# shared env is inherited by BOTH the build and the run, so build
# flags go here. Builds default to no debuginfo for speed; opt back
# in for hung-job gdb dumps and cap jobs to stay within memory:
CARGO_PROFILE_RELEASE_DEBUG: "1"
CARGO_BUILD_JOBS: "1"
baseline:
ref: v45.0.0
env:
# per-side env only reaches the benchmark run, not the build
DATAFUSION_RUNTIME_MEMORY_LIMIT: 1G
changed:
ref: v46.0.0
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: 2GFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
|
Hi @Rich-T-kid, your benchmark configuration could not be parsed (#10765 (comment)). Error: Usage: Any benchmark name is accepted: Per-side configuration ( env:
# shared env is inherited by BOTH the build and the run, so build
# flags go here. Builds default to no debuginfo for speed; opt back
# in for hung-job gdb dumps and cap jobs to stay within memory:
CARGO_PROFILE_RELEASE_DEBUG: "1"
CARGO_BUILD_JOBS: "1"
baseline:
ref: v45.0.0
env:
# per-side env only reaches the benchmark run, not the build
DATAFUSION_RUNTIME_MEMORY_LIMIT: 1G
changed:
ref: v46.0.0
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: 2GFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels env: |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
show benchmark queue |
|
Hi @Rich-T-kid, you asked to view the benchmark queue (#10765 (comment)).
File an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (33cded2) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels env: |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
run benchmark cast_kernels |
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
Author
|
show benchmark queue |
|
Hi @Rich-T-kid, you asked to view the benchmark queue (#10765 (comment)).
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (d6a16fb) to 6bb5e2b (merge-base) diff Run configurationrun benchmark cast_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
Author
🚀 |
Rich-T-kid
force-pushed
the
rich-T-kid/bench-dict-append-array-impl
branch
from
August 20, 2026 01:05
d6a16fb to
faca997
Compare
Contributor
Author
|
run benchmark cast_kernels |
Contributor
Author
|
run benchmark cast_kernels |
1 similar comment
Contributor
Author
|
run benchmark cast_kernels |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (dca89f9) to 365c760 (merge-base) diff Run configurationrun benchmark cast_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (dca89f9) to 365c760 (merge-base) diff Run configurationrun benchmark cast_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Rich-T-kid
force-pushed
the
rich-T-kid/bench-dict-append-array-impl
branch
from
August 20, 2026 02:35
dca89f9 to
e327c25
Compare
Rich-T-kid
force-pushed
the
rich-T-kid/bench-dict-append-array-impl
branch
from
August 20, 2026 02:35
e327c25 to
54a655d
Compare
Rich-T-kid
marked this pull request as ready for review
August 20, 2026 02:39
Contributor
Author
|
reproducible results this is ready for review now @Jefffrey |
Contributor
|
run benchmark cast_kernels |
Contributor
|
fyi need that indentation on |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Jefffrey
approved these changes
Aug 20, 2026
| let start = offsets[row_idx].as_usize(); | ||
| let end = offsets[row_idx + 1].as_usize(); | ||
| // SAFETY: offsets are valid by GenericByteArray invariants | ||
| let bytes = unsafe { raw_data.get_unchecked(start..end) }; |
Contributor
There was a problem hiding this comment.
would be nice if we could find a way to deduplicate this with get_or_insert_key without regressing performance 🤔
Contributor
Author
There was a problem hiding this comment.
I think placing this in a anon func would be the best way to solve this.
Contributor
Author
ahh okay makes sense. |
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (54a655d) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
thank you @Jefffrey 🚀 |
13 tasks
Contributor
Author
|
run benchmark cast_kernels |
|
Hi @Rich-T-kid, your benchmark configuration could not be parsed (#10765 (comment)). Error: Usage: Any benchmark name is accepted: Per-side configuration ( env:
# shared env is inherited by BOTH the build and the run, so build
# flags go here. Builds default to no debuginfo for speed; opt back
# in for hung-job gdb dumps and cap jobs to stay within memory:
CARGO_PROFILE_RELEASE_DEBUG: "1"
CARGO_BUILD_JOBS: "1"
baseline:
ref: v45.0.0
env:
# per-side env only reaches the benchmark run, not the build
DATAFUSION_RUNTIME_MEMORY_LIMIT: 1G
changed:
ref: v46.0.0
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: 2GFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (891c7ff) to 5ec9eaf (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (891c7ff) to 5ec9eaf (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
the utf8/binary -> dict<_,utf8/binary> currently calls
append_value()in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls.What changes are included in this PR?
new
append_array()method on the byteDictionaryBuilder.Are these changes tested?
yes & benchmarked
Are there any user-facing changes?
yes, new
append_array()method on the byteDictionaryBuilder.