SIANXKE-473: implement solver that directly uses the Gurobi API by MLackenbucher · Pull Request #13 · anexia/dotnetcore-mathematical-program

MLackenbucher · 2025-10-17T10:17:18Z

No description provided.

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

codecov · 2025-10-17T10:18:35Z

Codecov Report

❌ Patch coverage is 53.64583% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.79%. Comparing base (035ca66) to head (6dbb108).

Files with missing lines	Patch %	Lines
...ia.MathematicalProgram/Solve/GurobiNativeSolver.cs	18.91%	58 Missing and 2 partials ⚠️
...c/Anexia.MathematicalProgram/Solve/IlpCbcSolver.cs	0.00%	8 Missing and 2 partials ⚠️
...aticalProgram/Solve/ConstraintProgrammingSolver.cs	0.00%	6 Missing and 1 partial ⚠️
src/Anexia.MathematicalProgram/Solve/IlpSolver.cs	84.00%	3 Missing and 1 partial ⚠️
src/Anexia.MathematicalProgram/Solve/LPSolver.cs	50.00%	3 Missing and 1 partial ⚠️
...nexia.MathematicalProgram/Result/ResultHandling.cs	96.07%	1 Missing and 1 partial ⚠️
...MathematicalProgram/Model/Expression/Constraint.cs	50.00%	1 Missing ⚠️
.../Anexia.MathematicalProgram/Result/SolverResult.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   76.69%   79.79%   +3.10%     
==========================================
  Files          45       46       +1     
  Lines         811      980     +169     
  Branches       92      118      +26     
==========================================
+ Hits          622      782     +160     
- Misses        144      158      +14     
+ Partials       45       40       -5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…tions/checkout-6 Bump actions/checkout from 4 to 6

…tions/setup-dotnet-5 Bump actions/setup-dotnet from 4 to 5

MLackenbucher · 2026-07-14T15:39:53Z

@melaniesi @sarahkatharina gerne auch mal drüber schauen und Anmerkungen geben wenn ihr noch welche habt

markstrempel · 2026-07-29T15:07:36Z

-      - name: Verify commit exists in origin/main
-        run: |
-          git fetch --no-tags --prune --depth=1 origin +refs/heads/*:refs/remotes/origin/*
-          git branch --remote --contains | grep origin/main
-


we should keep this check

markstrempel · 2026-07-29T15:08:01Z


    <ItemGroup>
-        <PackageReference Update="Google.OrTools" Version="9.15.6755" />
+        <PackageReference Update="Google.OrTools" Version="9.14.6206" />


why the downgrade?

OR Tools 9.15.x has problems with Gurobi 13.

waiting for google/or-tools#5272

markstrempel · 2026-07-30T06:12:35Z

+            GRB.Status.OPTIMAL => objectiveValue is null || bestBound is null
+                ? throw new MathematicalProgramException("Mathematical program could not be solved.")
+                : SolverResult(SolverResultStatus.Optimal, false, solutionValues, objectiveValue,
+                    bestBound, true, true),
+            GRB.Status.SUBOPTIMAL => objectiveValue is null || bestBound is null
+                ? throw new MathematicalProgramException("Mathematical program could not be solved.")
+                : SolverResult(SolverResultStatus.Feasible, false, solutionValues, objectiveValue,
+                    bestBound, true),
+            GRB.Status.TIME_LIMIT => objectiveValue is null || bestBound is null
+                ? throw new MathematicalProgramException("Mathematical program could not be solved.")
+                : SolverResult(SolverResultStatus.Timelimit, false, solutionValues, objectiveValue,
+                    bestBound, true),
+            GRB.Status.INTERRUPTED => objectiveValue is null || bestBound is null
+                ? throw new MathematicalProgramException("Mathematical program could not be solved.")
+                : SolverResult(SolverResultStatus.CancelledByUser, false, solutionValues, objectiveValue,
+                    bestBound, true),
+            GRB.Status.MEM_LIMIT => objectiveValue is null || bestBound is null
+                ? throw new MathematicalProgramException("Mathematical program could not be solved.")
+                : SolverResult(SolverResultStatus.UnknownStatus, false, solutionValues, objectiveValue,
+                    bestBound, true),
+            GRB.Status.UNBOUNDED => objectiveValue is null || bestBound is null
+                ? throw new MathematicalProgramException("Mathematical program could not be solved.")
+                : SolverResult<TVariable, TCoefficient, TVariableInterval>(SolverResultStatus.Unbounded, false),
+            GRB.Status.INFEASIBLE => SolverResult<TVariable, TCoefficient, TVariableInterval>(
+                SolverResultStatus.Infeasible, false, isFeasible: false),


I think when can check objectiveValue is null || bestBound is null once before the switch

markstrempel · 2026-07-30T06:17:06Z

+            if (solverParameter.ExportModelFilePath is not null)
+            {
+                logger?.LogInformation("Exporting model to {ExportModelFilePath}", solverParameter.ExportModelFilePath);
+
+                gurobiModel.Write(solverParameter.ExportModelFilePath);
+            }


for long running models it might be sensible to move this export before the optimization

markstrempel · 2026-07-30T06:21:01Z

 using Google.OrTools.ModelBuilder;
+using Gurobi;
 using Microsoft.Extensions.Logging;
+using static Google.OrTools.Init.operations_research_init;


remove unused import

markstrempel · 2026-07-30T06:54:02Z

one test, one assert

markstrempel · 2026-07-30T06:56:14Z

one test, one assert

markstrempel · 2026-07-30T06:56:28Z

one test, one assert

markstrempel · 2026-07-30T07:02:00Z

does any of these tests provide any value/insight/whatsoever?

Asserts correct solver initialization

markstrempel · 2026-07-30T07:02:26Z

one test, one assert

markstrempel · 2026-07-30T07:14:54Z

+    {
+        try
+        {
+            var env = new GRBEnv(true);


Suggested change

var env = new GRBEnv(true);

using var env = new GRBEnv(true);

markstrempel · 2026-07-30T07:15:07Z

+
+            env.Start();
+
+            var gurobiModel = new GRBModel(env);


Suggested change

var gurobiModel = new GRBModel(env);

using var gurobiModel = new GRBModel(env);

MLackenbucher requested a review from markstrempel October 17, 2025 10:17

MLackenbucher assigned markstrempel Oct 17, 2025

MLackenbucher added the hacktoberfest-accepted label Oct 17, 2025

markstrempel suggested changes Oct 17, 2025

View reviewed changes

MLackenbucher force-pushed the feature/MLA_SIANXKE-473_gurobi-without-ortools branch from 4c2f431 to a9068ae Compare November 27, 2025 13:58

MLackenbucher added 2 commits July 10, 2026 12:18

Merge pull request #3 from MLackenbucher/dependabot/github_actions/ac…

3132050

…tions/checkout-6 Bump actions/checkout from 4 to 6

Merge pull request #2 from MLackenbucher/dependabot/github_actions/ac…

dc06bf1

…tions/setup-dotnet-5 Bump actions/setup-dotnet from 4 to 5

MLackenbucher force-pushed the feature/MLA_SIANXKE-473_gurobi-without-ortools branch 16 times, most recently from 9368d31 to 83baf76 Compare July 14, 2026 15:38

MLackenbucher requested review from melaniesi and sarahkatharina July 14, 2026 15:38

MLackenbucher requested a review from markstrempel July 14, 2026 15:40

MLackenbucher force-pushed the feature/MLA_SIANXKE-473_gurobi-without-ortools branch 2 times, most recently from ef0ddef to 003a7e4 Compare July 15, 2026 08:40

markstrempel suggested changes Jul 30, 2026

View reviewed changes

markstrempel reviewed Jul 30, 2026

View reviewed changes

SIANXKE-473: implement solver that directly uses the Gurobi API

6dbb108

MLackenbucher force-pushed the feature/MLA_SIANXKE-473_gurobi-without-ortools branch from 003a7e4 to 6dbb108 Compare August 3, 2026 11:56

MLackenbucher requested a review from markstrempel August 3, 2026 11:56

	var env = new GRBEnv(true);
	using var env = new GRBEnv(true);

	var gurobiModel = new GRBModel(env);
	using var gurobiModel = new GRBModel(env);

Uh oh!

Conversation

MLackenbucher commented Oct 17, 2025

Uh oh!

codecov Bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MLackenbucher commented Jul 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 17, 2025 •

edited

Loading