Skip to content

fix: be less strict about range request responses - #3404

Closed
costela wants to merge 1 commit into
androidx:releasefrom
exaring:leo.antunes/be-less-strict-about-range-request-responses
Closed

fix: be less strict about range request responses#3404
costela wants to merge 1 commit into
androidx:releasefrom
exaring:leo.antunes/be-less-strict-about-range-request-responses

Conversation

@costela

@costela costela commented Sep 4, 2026

Copy link
Copy Markdown

The code currently only does manual byte skipping for HTTP responses with a 200 status. There are other valid status codes that may be returned for a non-range response (e.g. 203), so we should be less strict about it.

@google-cla

google-cla Bot commented Sep 4, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@costela
costela force-pushed the leo.antunes/be-less-strict-about-range-request-responses branch from ed3b3f7 to 6e62405 Compare September 4, 2026 12:24
The code currently only does manual byte skipping for HTTP responses
with a 200 status. There are other valid status codes that may be
returned for a non-range response (e.g. 203), so we should be less
strict about it.
@costela
costela force-pushed the leo.antunes/be-less-strict-about-range-request-responses branch from 6e62405 to 3c59ced Compare September 4, 2026 12:30
@rohitjoins rohitjoins self-assigned this Sep 10, 2026
@rohitjoins

Copy link
Copy Markdown
Contributor

@costela

Thank you for the PR.

Would it be possible to open a new PR from an individual-owned fork? We can't push changes to organization-owned forks like this one unless we have collaborator access. If that's not possible then we can still merge this PR but it will result in an 'evil' merge. See more info here: https://github.com/androidx/media/blob/release/CONTRIBUTING.md#push-access-to-pr-branches

Additionally, please ensure your pull request targets the main branch instead of release. All of our ongoing development and bug fixes need to be integrated into main first.

@costela

costela commented Sep 10, 2026

Copy link
Copy Markdown
Author

@rohitjoins ah, my bad! Just recreated as #3410 ✔️

Closing this one in favor of the new...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants