Serialize audio capability callbacks on receiver handler - #3388
Open
ajay-jg wants to merge 3 commits into
Open
Conversation
1 task
ajay-jg
marked this pull request as ready for review
September 12, 2026 05:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3386.
Context
Some Android devices invoke
AudioDeviceCallbackfrom an OEM thread instead of theHandlersupplied during registration. This violates theAudioManagercallback contract and can notifyDefaultAudioSinkoff its playback looper.The resulting crash is:
Change
This change reposts audio-device capability updates to the
AudioCapabilitiesReceiverhandler only for the confirmed affected device cohort.The workaround is enabled only when all of the following are true:
MediaLibraryInfo.enableWorkarounds()is enabled.SDK_INT < 38.All other devices retain the existing direct callback path. The API 38 gate allows this workaround to retire where CTS verifies that
AudioManagerinvokes callbacks on the supplied handler thread.For removed devices, routed-device invalidation and capability recalculation run in the same handler task, preserving receiver state ordering.
Testing
MediaLibraryInfo.enableWorkarounds()is false../gradlew :lib-exoplayer:testDebugUnitTest --tests androidx.media3.exoplayer.audio.AudioCapabilitiesReceiverWrongThreadTest --no-daemonpasses.