fix: save_config, execute_command, and main are annotated as - #1
Open
andrewwhitecdw wants to merge 1 commit into
Open
andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
andrewwhitecdw
added
the
sweep-approved
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
andrewwhitecdw
force-pushed
the
bugfix/bobber-noreturn-annotations-on-functions-that
branch
from
August 27, 2026 22:37
14f4733 to
7adddea
Compare
andrewwhitecdw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
bobber/bobber.py: save_config, execute_command, and main are annotated as.Changes
bobber/bobber.py: save_config, execute_command, and main are annotated as.Details
This change addresses in
bobber/bobber.py: save_config, execute_command, and main are annotated as NoReturn even though they return normally to their callers, which misleads type checkers and callers; after correcting the annotations, the NoReturn import is unused..Tests
tests/test_bobber_annotations.pyContributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).