Skip to content

add ad488x dts - #3463

Open
amiclaus wants to merge 3 commits into
mainfrom
staging/ad488x-dts
Open

add ad488x dts#3463
amiclaus wants to merge 3 commits into
mainfrom
staging/ad488x-dts

Conversation

@amiclaus

@amiclaus amiclaus commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

PR Description

arm: dts: xilinx: add dts for ad4880 on zedboard
arm: dts: xilinx: add dts for ad4883 on zedboard
arm: dts: xilinx: add dts for ad4884 on zedboard

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@nunojsa

nunojsa commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Seems that there are valid CI complains!

@gastmaier

gastmaier commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator 

build_gcc_arm / build: arch/arm/boot/dts/xilinx/zynq-zed-ad4880.dts#L0
compile_devicetree: 
DTS does not contain 'hdl_project:' tag
 Either:
  1. Create a 'hdl_project' tag for it
 OR
  2. add it in file 'ci/travis/dtb_build_test_exceptions'

@amiclaus
amiclaus force-pushed the staging/ad488x-dts branch from 434c450 to 87539c4 Compare July 28, 2026 13:14
amiclaus
amiclaus commented Jul 28, 2026
View reviewed changes

@amiclaus amiclaus left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2:

  • add header for ad4080 with hdl tag
  • fix build warnings

nunojsa
nunojsa approved these changes Jul 30, 2026
View reviewed changes

@nunojsa nunojsa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same nit as the other PR

@amiclaus
amiclaus marked this pull request as draft July 30, 2026 13:51
@amiclaus
amiclaus force-pushed the staging/ad488x-dts branch from 87539c4 to c55b7b0 Compare August 7, 2026 08:17
amiclaus
amiclaus commented Aug 7, 2026
View reviewed changes

@amiclaus amiclaus left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3:

  • drop the axi_clk fixed-clock; clock both AXI-ADC backends from Zynq PS FCLK0 (<&clkc 15>).
  • model the ADF4350 output as a standalone adf4350_clkout fixed-clock; remove its clock-provider props.

@amiclaus
amiclaus marked this pull request as ready for review August 7, 2026 08:18
nunojsa
nunojsa requested changes Aug 13, 2026
View reviewed changes
Comment thread arch/arm/boot/dts/xilinx/zynq-zed-ad4883.dts Outdated
compatible = "adi,axi-ad408x";
reg = <0x44A10000 0x10000>;
clocks = <&axi_clk>;
spibus-connected = <&adc_ad4883>;

@nunojsa nunojsa Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is using the new backend stuff right? So no need for adi,axi-ad408x. What you actually need is #io-backend-cells = <0>;

Same for all other DTs

@amiclaus amiclaus Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adi,axi-ad408x is needed for

linux/drivers/iio/adc/adi-axi-adc.c

Line 456 in d46c5bf

.ops = &adi_ad408x_ops,

Comment thread arch/arm/boot/dts/xilinx/zynq-zed-ad4883.dts Outdated
adi,source-bus-type = <2>;
adi,destination-bus-width = <64>;
adi,destination-bus-type = <0>;
};

@nunojsa nunojsa Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above dma-channel is no longer needed (for some time now). The driver can know all of the above from the IP during probe

Comment thread arch/arm/boot/dts/xilinx/zynq-zed-ad4880.dts
compatible = "adi,axi-ad408x";
reg = <0x44A10000 0x10000>;
clocks = <&axi_clk>;
clocks = <&clkc 15>;

@nunojsa nunojsa Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this fixing something introduced by this patch series?!

@amiclaus
arm: dts: xilinx: add dts for ad4880 on zedboard
bae0393 
Add a device tree for the AD4880 SAR ADC on the ZedBoard.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
@amiclaus
arm: dts: xilinx: add dts for ad4883 on zedboard
9663809 
Add a device tree for the AD4883 SAR ADC on the ZedBoard.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
@amiclaus
arm: dts: xilinx: add dts for ad4884 on zedboard
7998c3c 
Add a device tree for the AD4884 SAR ADC on the ZedBoard.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
@amiclaus
amiclaus force-pushed the staging/ad488x-dts branch from c55b7b0 to 7998c3c Compare August 13, 2026 10:03
amiclaus
amiclaus commented Aug 13, 2026
View reviewed changes

@amiclaus amiclaus left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4:

  • drop deprecated adi,channels/dma-channel@0 node from rx_dma
  • replace spibus-connected with #io-backend-cells = <0>
  • squash fixup commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nunojsa nunojsa nunojsa requested changes
@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner
@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner
@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner
@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner
@buha buha Awaiting requested review from buha buha is a code owner
@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner
@danmois danmois Awaiting requested review from danmois danmois is a code owner
@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner
@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner
@stefpopa stefpopa Awaiting requested review from stefpopa stefpopa is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amiclaus @nunojsa @gastmaier