Skip to content

test(mocktesting): verify parallel delay - #1437

Open
dajiaohuang wants to merge 1 commit into
amygdala-labs:mainfrom
dajiaohuang:test/mocktesting-parallel-delay
Open

dajiaohuang wants to merge 1 commit into
amygdala-labs:mainfrom
dajiaohuang:test/mocktesting-parallel-delay

Conversation

@dajiaohuang

Copy link
Copy Markdown

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Test fix for issue #1436.

What is the current behavior? (You can also link to an open issue here)

mocktesting.TestT_Parallel leaves ParallelDelay at zero and compares after against before + delay in the wrong direction. A no-op Parallel implementation therefore passes the test.

What is the new behavior (if this is a feature change or bug fix)

The test configures a 10ms delay and verifies elapsed time is at least that duration. A temporary no-delay probe now fails the test; the original test passed the same probe.

Does this PR introduce a breaking change?

No.

Associated Issues

Closes #1436.

Required for all PRs:

  • I have read and agree to follow the Code of Conduct for this project.
  • I have read and followed the guidelines in the Contributor's Guide.
  • I have read the Security Guide; this change does not concern a security issue.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have written the appropriate test for this change.
  • Documentation update: not applicable.
  • I have run the linter: golangci-lint v1.61.0 was obtained and checksum-verified, but its run failed before linting with failed to initialize build cache at : mkdir : The system cannot find the path specified under local Go 1.26.3.
  • All tests are passing locally: go test ./mocktesting -count=1 passed; the full suite was not run because it includes actual-chain/Docker integration tests outside this assignment's permitted synthetic-only scope.
  • PR title follows Conventional Commits.

git diff --check passed. gofmt reported no formatting changes when checked with line endings normalized; the checkout's CRLF line endings were preserved.

@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@dajiaohuang is attempting to deploy a commit to the Strangelove Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TestT_Parallel does not detect missing delays

1 participant