Repository navigation
test(mocktesting): verify parallel delay - #1437
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
|
@dajiaohuang is attempting to deploy a commit to the Strangelove Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test fix for issue #1436.
What is the current behavior? (You can also link to an open issue here)
mocktesting.TestT_ParallelleavesParallelDelayat zero and comparesafteragainstbefore + delayin the wrong direction. A no-opParallelimplementation therefore passes the test.What is the new behavior (if this is a feature change or bug fix)
The test configures a 10ms delay and verifies elapsed time is at least that duration. A temporary no-delay probe now fails the test; the original test passed the same probe.
Does this PR introduce a breaking change?
No.
Associated Issues
Closes #1436.
Required for all PRs:
failed to initialize build cache at : mkdir : The system cannot find the path specifiedunder local Go 1.26.3.go test ./mocktesting -count=1passed; the full suite was not run because it includes actual-chain/Docker integration tests outside this assignment's permitted synthetic-only scope.git diff --checkpassed.gofmtreported no formatting changes when checked with line endings normalized; the checkout's CRLF line endings were preserved.