Skip pydocstyle tests if it can't be imported#579
Merged
Conversation
This change is modeled after ament_cppcheck, which is also skipped on some platforms. Unlike that change, however, we need to handle invocation of ament_pep257 from downstream pytests, so I implemented that using a SkipTest exception and an additional wrapper around `main()` so that direct ament_pep257 command line invocations still look okay. The changes to `get_xunit_output` and addition of `write_xunit_output` were taken from ament_cppcheck. Signed-off-by: Scott K Logan <logans@cottsay.net>
mjcarroll
approved these changes
Apr 22, 2026
InvincibleRMC
approved these changes
Apr 22, 2026
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
cottsay/skip-pydocstyle
branch
from
adb6c0a to
514734b
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is modeled after ament_cppcheck, which is also skipped on some platforms. Unlike that change, however, we need to handle invocation of ament_pep257 from downstream pytests, so I implemented that using a SkipTest exception and an additional wrapper around
main()so that direct ament_pep257 command line invocations still look okay.The changes to
get_xunit_outputand addition ofwrite_xunit_outputwere taken from ament_cppcheck.This is intended to be a sort of stopgap to get us through the Lyrical release until something more robust like #578 can safely land.