[ament_cmake_lint_cmake] Add file exclude support (#458)#546
Open
guillaumeautran wants to merge 3 commits into
Open
[ament_cmake_lint_cmake] Add file exclude support (#458)#546guillaumeautran wants to merge 3 commits into
guillaumeautran wants to merge 3 commits into
Conversation
guillaumeautran
force-pushed
the
ga_cmake_lint_cmake
branch
2 times, most recently
from
d2e96e1 to
e6c1d00
Compare
Author
|
@Benjamin-Tan and @sloretz, would you be the right people to review this PR? |
In the `ament_lint_cmake` CMake function, the optional list argument `EXCLUDE` can now be used as an exclusion specifier. The `ament_cmake_lint_cmake` respects the `AMENT_LINT_AUTO_FILE_EXCLUDE` variable. Signed-off-by: Guillaume Autran <gautran@clearpath.ai>
The `ament_cmake_pep257` respects the `AMENT_LINT_AUTO_FILE_EXCLUDE` variable. Signed-off-by: Guillaume Autran <gautran@clearpath.ai>
The `ament_cmake_xmllit` respects the `AMENT_LINT_AUTO_FILE_EXCLUDE` variable. Signed-off-by: Guillaume Autran <gautran@clearpath.ai>
guillaumeautran
force-pushed
the
ga_cmake_lint_cmake
branch
from
e6c1d00 to
ba1a1ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
ament_lint_cmakeCMake function, the optional list argumentEXCLUDEcan now be used as an exclusion specifier. Theament_cmake_lint_cmakerespects theAMENT_LINT_AUTO_FILE_EXCLUDEvariable.