Repository navigation
fix: control disc dupe - #2222
Merged
Merged
Conversation
drtheodor
added
T: Bugfix
github-actions
Bot
added
S: Untriaged
drtheodor
removed
the
S: Untriaged
github-actions
Bot
added
S: Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This PR fixes a bug where interacting with a control disc in offhand and another item in main hand - it'd duplicate the item in the main hand to the offhand.
Why / Balance
Dupe.
Technical details
Control disc checks if it was interacted with in a tardis dimension and if so it'd fail with the item stack in the main hand, which wasn't guaranteed to be the disc stack.
Media
https://discord.com/channels/1213989169878274068/1215595405270589500/1555716041663975434
Requirements
Breaking changes
Changelog