-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ledger-cleanup): 台帳タスクの実装完了を決定論的に検証し 2 経路へ配線する #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| [package] | ||
| name = "cli-ledger-cleanup" | ||
| version = "0.1.0" | ||
| edition = "2021" | ||
|
|
||
| [[bin]] | ||
| name = "cli-ledger-cleanup" | ||
| path = "src/main.rs" | ||
|
|
||
| [dependencies] | ||
| # 台帳の解釈は lib-ledger に集約する (ADR-024)。本 exe は CLI 面 (引数・出力・exit コード) だけを担う。 | ||
| lib-ledger = { path = "../lib-ledger" } | ||
|
|
||
| # 外部 crate 依存は足さない。本 exe は「実装が完了したか」を判定して後始末の可否を決める | ||
| # ゲートであり、供給元が増えるほど判定を曲げられる面が広がる (lib-ledger と同じ論理)。 | ||
|
|
||
| # [profile.release] は workspace root (Cargo.toml) に集約 (ADR-026) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
master-refの入力を完全性検証前に使用しないでください。cli-ledger-cleanupはハッシュ対象ですが、ここでmaster-ref/target/release/cli-ledger-cleanupを実行します。Verify gate integrityは Line 459-467 の後段です。master-refの書込み制限が回避された場合、改ざん済みの実行ファイルが先に runner 上で実行され、publish/や後続判定へ影響できます。また、ここで読む
master-ref/docs/claude-code-web-tasks.mdはハッシュ対象に含まれていません。台帳を改ざんすると、未完了の実装を完了として判定できます。Guard はpublish/の差分だけを検査するため、台帳の改変を検出できません。Verify gate integrityをこの step より前へ移動してください。台帳も同じ完全性検証の対象に追加してください。この指摘は、完了判定 step のmaster-ref入力と同 workflow の完全性検証の順序に基づきます。Also applies to: 426-439
🤖 Prompt for AI Agents