docs(adr): ADR-062 月次ハーネス ROI レビューを追加 (WP-12 step 2/3 消化、Phase 3) - #332
Merged
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChanges月次telemetry発火実績に基づくハーネスROIレビューをADR-062として定義し、非アクティブ化候補の判定・ユーザー承認・retention・出力仕様を既存ADRと計画文書へ反映しました。 月次ハーネス ROI レビュー
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🤖 PR Monitor 分析 (GitHub Actions バックストップ)
Applicable Findings (Critical / High / Major)該当なし (CodeRabbit レビュー未着のため findings 0 件) Applicable Findings (Medium 以下)(該当なし) Filtered (not applicable)(該当なし) 軽量サマリー (diff 概要)全 8 ファイル変更、すべて
新規 ADR-062 (月次ハーネス ROI レビュー) を追加し、既存の ADR-053 / ADR-061 の「4 週間非観測での撤去判定」を telemetry 発火実績ベースの機械 promote (連続 2 か月発火 0) に接続する内容。WP-12 step 2/3 の進捗として todo 系ドキュメントも整理されている。 次のアクション
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/harness-improvement-plan.md (2)
258-258: 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win個人のローカルパスを文書から除去してください。
C:\Users\owner\work\claude-code-skillsはユーザー名を露出し、他環境では利用できません。$CLAUDE_SKILLS_REPOと相対パス、または固定した commit ID だけを記載してください。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/harness-improvement-plan.md` at line 258, Remove the personal local path C:\Users\owner\work\claude-code-skills from the deployment configuration documentation around the hooks-stop-quality and push-runner-config.toml guidance. Replace it with $CLAUDE_SKILLS_REPO plus a relative path, or with a fixed commit ID, while preserving the documented cross-shell path behavior.
254-267: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift未コミットの L3 skill を「実装完了」として扱わないでください。
Phase 3 は「実装完了」と記載されていますが、skills repository の commit/PR は未実施です。別リポジトリの未固定状態を完了扱いすると、再現・ロールバック・監査ができません。少なくとも immutable な commit を記録してから完了にするか、現状を「実装済み・未 land」と明示してください。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/harness-improvement-plan.md` around lines 254 - 267, Update the Phase 3 completion status in the implementation plan to avoid treating the uncommitted L3 skill changes as complete. Record an immutable commit or PR reference for the skills repository before marking the phase complete; otherwise explicitly label it as implemented but not landed, including its uncommitted status.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/adr/adr-062-monthly-harness-roi-review.md`:
- Around line 134-136: ADR の Phase 4 と last-run 更新条件を明確化し、cli-telemetry-report
の失敗時または degraded により promote を抑止した場合は state を更新せず stale
のまま保持する契約を追記してください。完全なレポート取得とユーザー確認が成功した場合のみ last_run を更新することを明記してください。
- Around line 43-46:
撤去判定の正式基準を「連続2か月発火0」に統一し、旧「4週間」条件が残らないよう更新してください。docs/adr/adr-062-monthly-harness-roi-review.md:43-46では2か月基準を唯一の正式基準として明示し、docs/adr/adr-053-stop-tool-call-leak-detection.md:150-157とdocs/adr/adr-061-tool-call-leak-hardfail-recovery.md:173-180では旧条件をADR-062へ委譲する記述に置き換え、両ADRの判定契約を揃えてください。
In `@docs/todo16.md`:
- Line 302: Update the ADR-055 warm-up date reference in the telemetry
documentation to use the ADR-062 start date of 2026-07-15, while retaining the
28-day result of approximately 2026-08-12 and the existing ADR-062 link.
---
Outside diff comments:
In `@docs/harness-improvement-plan.md`:
- Line 258: Remove the personal local path
C:\Users\owner\work\claude-code-skills from the deployment configuration
documentation around the hooks-stop-quality and push-runner-config.toml
guidance. Replace it with $CLAUDE_SKILLS_REPO plus a relative path, or with a
fixed commit ID, while preserving the documented cross-shell path behavior.
- Around line 254-267: Update the Phase 3 completion status in the
implementation plan to avoid treating the uncommitted L3 skill changes as
complete. Record an immutable commit or PR reference for the skills repository
before marking the phase complete; otherwise explicitly label it as implemented
but not landed, including its uncommitted status.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0576314d-9e50-4088-9b85-b76bc01e9679
📒 Files selected for processing (9)
CLAUDE.mddocs/adr/adr-053-stop-tool-call-leak-detection.mddocs/adr/adr-055-firing-telemetry-collection.mddocs/adr/adr-061-tool-call-leak-hardfail-recovery.mddocs/adr/adr-062-monthly-harness-roi-review.mddocs/harness-improvement-plan.mddocs/monthly-harness-roi-review-plan.mddocs/todo-summary2.mddocs/todo16.md
Contributor
🤖 PR Monitor 分析 (GitHub Actions バックストップ)
Applicable Findings (Critical / High / Major)
Applicable Findings (Medium 以下)
Filtered (not applicable)該当なし (全 5 件とも ADR 矛盾・プラットフォーム範囲外・sensitive-file・スコープ外のいずれにも該当せず、docs-only PR でも適用対象の cross-reference / データ整合性 / セキュリティ観点の指摘のため applicable と判定) 次のアクション
|
月次ハーネス ROI レビュー (docs/monthly-harness-roi-review-plan.md) の Phase 3。L3 skill (/monthly-review、skills repo で別途 commit) に対応する本 repo の docs を整備する。 - ADR-062 新規: 月次ハーネス ROI レビューの背景/設計決定/ユーザー決定事項を正式記録 (試験運用、ADR-039 3 点セット)。cli-telemetry-report (L2) + SessionStart reminder (L1、#331) + /monthly-review skill (L3) の 3 層。 - ADR-055 amendment: WP-12 step 2/3 消化 + 出力先の週次→月次変更。 - ADR-053 / ADR-061 追記: 撤去判定 (4 週間非観測) を月次レビューが連続 2 か月発火 0 で機械 promote。 - CLAUDE.md index に ADR-062 追加。 - todo 整理: todo-summary2.md の順位 307/308/312 削除、todo16.md の WP-12 step2/step3/retention セクション削除、harness-improvement-plan.md の WP-12 状態更新。 docs-only。pnpm lint:md 全通。
aloekun
force-pushed
the
docs/adr-062-monthly-roi-review
branch
from
July 30, 2026 06:33
e07220f to
d9f9337
Compare
Contributor
🤖 PR Monitor 分析 (GitHub Actions バックストップ)
Applicable Findings (Critical / High / Major)
Applicable Findings (Medium 以下)
Filtered (not applicable)該当なし 解決済み (今回確認)
次のアクション
|
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
月次ハーネス ROI レビュー (
docs/monthly-harness-roi-review-plan.md) の Phase 3 (PR-3 後半)。L3 skill (/monthly-review) の作成に対応する本 repo の docs を整備し、ADR-055 の WP-12 step 2/3 を消化する。3 層構成 (ADR-062): L1 SessionStart reminder (PR #331 でマージ済) + L2
cli-telemetry-reportexe (PR #330 でマージ済) + L3/monthly-reviewskill (skills repo で別途 commit)。本 PR はこれらを正式記録する ADR + 既存 ADR への追記 + todo 整理を担う docs-only PR。変更内容
docs/adr/adr-062-monthly-harness-roi-review.md): 月次ハーネス ROI レビューの背景 / 設計決定 / ユーザー決定事項を正式記録 (試験運用、ADR-039 3 点セット)。todo-summary2.mdの順位 307/308/312 削除、todo16.mdの WP-12 step 2 / step 3 / retention セクション削除、harness-improvement-plan.mdの WP-12 状態更新 (step 2-3 + retention を ADR-062 で消化)。順位 315 の 307/308 参照を ADR-062 に repoint。検証
pnpm lint:md全通 (117 ファイル、0 error)補足
monthly-review/SKILL.md+evals/) は skills repo ($CLAUDE_SKILLS_REPO、別 git リポジトリ) で作成・deploy 済みだが、当該 repo の commit / PR は別フロー。Summary by CodeRabbit
新機能
ドキュメント