docs(adr): weekly-review 検出の ADR drift を修正 - #325
Merged
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughADR-012のCLI命名例を更新し、ADR-031の週次レビュー構成に5つのfacetと決定論的なファイルサイズスキャンを追加して、集約対象を明示しています。 ChangesADR-012 命名規約
ADR-031 週次レビュー・パイプライン
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🤖 PR Monitor 分析 (GitHub Actions バックストップ)
Applicable Findings (Critical / High / Major)(該当なし — レビュー指摘まだ0件) Applicable Findings (Medium 以下)(該当なし) Filtered (not applicable)(該当なし) 軽量サマリー (diff 概要)docs-only PR。変更は2ファイル、いずれも ADR 内の記述ドリフト修正:
いずれもコード変更を伴わない ADR 記述の事後修正 (実装と ADR の記述ドリフトの解消)。 次のアクション
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/adr/adr-031-weekly-review-pipeline.md`:
- Line 129: The ADR currently conflates the review facets with the post-review
aggregation workflow. In docs/adr/adr-031-weekly-review-pipeline.md lines
129-129, rename “aggregate facet” to “aggregate step”; in lines 163-175,
separate the aggregation step from the facet table or rename the relevant column
to “step,” ensuring the six review facets and the aggregate-weekly workflow step
are represented distinctly.
- Line 153: Update the aggregate-weekly documentation comment in the
weekly-review workflow to match the ADR’s six-report contract, or explicitly
identify the ADR as the authoritative source; keep the workflow’s report
aggregation behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 253582f8-79ba-4095-90ea-80f3ac4868be
📒 Files selected for processing (2)
docs/adr/adr-012-src-naming-convention.mddocs/adr/adr-031-weekly-review-pipeline.md
Contributor
🤖 PR Monitor 分析 (GitHub Actions バックストップ)
Applicable Findings (Critical / High / Major)(該当なし) Applicable Findings (Medium 以下)(該当なし) Filtered (not applicable)
次のアクション
|
2026-07-27 週次レビュー (WR-2026-07-27-A01/A02) で検出した docs-source drift を修正。 - ADR-012: `cli-` 例示テーブル(29行)・ビルドスクリプト例(40行)の旧クレート名 `cli-push-pipeline` を現行名 `cli-push-runner` に更新 (ADR-015 改名の反映漏れ)。リネーム記録・設計背景リンク(47/81行)は歴史的記述のため据え置き。 - ADR-031: takt workflow 構成表に実在する `review-todo-whole` / `review-jj-robustness-whole` / `file-length-watchlist` の3行を追加し、見出し・aggregate の report 数を実態 (5 review facets + file-size scan = 6 reports) に更新。 - weekly-review.yaml: aggregate-weekly コメントの report 数 (3→6) と対象ファイル表現を ADR と整合 (CodeRabbit PR #325 指摘②)。 - ADR-031 L129: aggregate は review facet でなく後段 step のため "aggregate facet"→"aggregate step" (CodeRabbit PR #325 指摘①)。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aloekun
force-pushed
the
docs-adr-drift-20260727
branch
from
July 28, 2026 09:18
e8a9348 to
31f936d
Compare
Contributor
🤖 PR Monitor 分析 (GitHub Actions バックストップ)
Applicable Findings (Critical / High / Major)(該当なし) Applicable Findings (Medium 以下)(該当なし) Filtered (not applicable)
次のアクション
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2026-07-27 の週次レビュー (
/weekly-review, ADR-031) が検出した docs-source drift を修正する docs-only PR。findingsWR-2026-07-27-A01/A02に対応。変更内容
ADR-012 (src 命名規約) — A01
cli-例示テーブル・ビルドスクリプト例の旧クレート名cli-push-pipelineを現行名cli-push-runnerに更新 (ADR-015 の改名が反映漏れだった)。ADR-031 (週次レビューパイプライン) — A02
takt workflow
weekly-review.yamlは実際には 5 review facets (simplicity / security / architecture / todo / jj-robustness) + 決定論的 file-size scan で構成されるが、ADR 本文が旧構成 (3〜4 facets) のまま乖離していた。以下の current-tense（現状記述）を実態に整合:review-todo-whole/review-jj-robustness-whole/file-length-watchlistの3行を追加、見出し更新据え置いた historical record (変更すると過去の事実を改竄するため):
検証
🤖 Generated with Claude Code
Summary by CodeRabbit