docs: ADR-045 に jj workspace の PR 運用知見を追記 + 改善タスク 3 件登録 (順位 233-235) - #228
Merged
Conversation
…e-feedback 採用候補 (PR #227)
…rk 誤検出) を追記 (初 PR 運用ケースの dogfood)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughADR-045 に secondary workspace で ChangesADR-045 更新と関連 TODO 追加
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PR #227(jj workspace での初 PR 運用ケース)の dogfood で得た知見を docs に反映する。独立した 2 つの変更を含む docs-only PR。
変更内容
1. ADR-045 に PR 運用知見を追記 (
docs/adr/adr-045-jj-workspace-parallel-sessions.md)jj workspace の初 PR 運用で判明した、ADR-045 に未記載だった運用上の制約を追記:
.git不在:jj workspace addで作った workspace は colocated にならず.gitを持たないため、gh ベースのコマンド(pnpm create-pr/pnpm merge-pr/cli-pr-monitor --monitor-only)がfatal: not a git repositoryで失敗する。pnpm push(jj git pushbackend)だけが動く非対称が初回検証(push 中心)で見落とされていたGIT_DIR回避策: メインリポジトリの.gitをGIT_DIRで参照する(Bash / PowerShell のコマンド例を併記)。jj はGIT_DIRを無視するため gh だけを制御し、jj 操作・monitor state 分離には影響しないlib-jj-helpersのBOOKMARK_SEARCH_REVSETS(@/@-/@--)の近接性衝突の注意(PR head 以外の bookmark を近接 revset に置くと誤検出)GIT_DIR自動注入 / direnv / colocated 化2. 改善タスク 3 件を todo に登録 (
docs/todo-summary.md/docs/todo13.md、順位 233-235)@コミットのみ見て誤分類するバグ(PR fix(cli-pr-monitor): 並列テスト flaky を tempfile 一意化と state path DI で構造的に解消 #227 観測)feedback-di-over-ambient-global-testsに serialization primitive 例外境界 + PR fix(cli-pr-monitor): 並列テスト flaky を tempfile 一意化と state path DI で構造的に解消 #227 具体例を追記(PR fix(cli-pr-monitor): 並列テスト flaky を tempfile 一意化と state path DI で構造的に解消 #227 post-merge-feedback T3-1 採用)種別
docs-only(ADR / todo ドキュメントの更新のみ、コード変更なし)。
Summary by CodeRabbit
.gitがないケースや、PR 操作で必要になる環境変数設定例を明確化しました。