docs(adr-040): step_timeout の sublinear/KV cache 説明追記と 600s/720s 数値整合 - #190
Merged
Conversation
- 線形 ceiling の formula を `180s × (32768 / 8192) = 720s` に修正し、 従来の `22 ms/token × 32768 = 721s` (丸め誤差由来) との不整合を解消 - canonical 600s が線形 720s を 120s (17%) 下回る差を sublinear/KV cache locality の定量表現として明文化 (per-token 22→18.3 ms/token と整合) - reference table の 600s と係数 section の 720s の関係を表直下に整合説明追記 - claude-code-web-tasks.md の順位 116 行を削除 (着手フロー step 3) 順位 116 (PR #145 T3-#1) 着手。todo-summary.md / todoN.md には当該順位の 行・詳細 section は既に存在しなかったため削除対象なし。
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughADR-040 の Changesドキュメント・タスク管理の更新
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
docs/claude-code-web-tasks.mdの 順位 116 (T3 / XS、PR #145 T3-#1) を着手。ADR-040 のstep_timeout比例係数 section に sublinear / KV cache locality の clarification を追記し、reference table の 600s と係数 derivation の 720s の数値整合を取った。背景の不整合
ADR-040 の線形 ceiling は header で 720s と記載されていたが、formula は
22 ms/token × 32768 = 721sを算出しており、丸め由来の数値不整合があった。変更内容
docs/adr/adr-040-local-llm-context-size.md:180s × (32768 / 8192) = 180s × 4 = 720sに修正し、721sとの不整合を解消(22 ms/token表示は丸め由来の近似である旨を併記)≈22 → ≈18.3 ms/tokenの 17% 改善と整合)docs/claude-code-web-tasks.md:トラッキング cleanup の所見
docs/todo-summary.mdと各docs/todoN.mdを確認したところ、順位 116 に対応する table 行・詳細 section は既に存在しなかった(PR #145 関連で残るのは順位 117 のエントリのみ)。そのため着手フロー step 3 (todo-summary 行削除) / step 4 (todoN.md section 削除) は削除対象なしで、claude-code-web-tasks.mdの行削除のみ実施した。検証
claude-code-web-tasks.mdの採用判定基準 2 を満たす)180s × 4 = 720s、(720 − 600) / 720 ≈ 17%、per-token(22 − 18.3) / 22 ≈ 17%が相互に整合https://claude.ai/code/session_01LyAvRfNsyLF1HNNb9hrQC6
Generated by Claude Code
Summary by CodeRabbit
リリースノート