fix: use serde private mod patch notation - #2886
Conversation
There was a problem hiding this comment.
lgtm!
context:
I think it is low cost and decent benefit. If there is any logic in there that someone wants access to, they need to find someone to maintain it officially so that their users do not experience repeated breakage from serde updates.
from serde-rs/serde#2980 (comment)
serde-rs/serde#2980 was released in a serde patch v1.0.225
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
let's get this out to get unblocked
I think we could also just remove the manual deserialize impl entirely?
https://github.com/alloy-rs/alloy/blob/main/crates/tx-macros/src/serde.rs#L228-L263
because I believe deriving the deserialize here would generate the same code but with a worse error message, although this would be preferred over having to maintain this
3 participants
Motivation
Solution
PR Checklist