Fix memory leak - #257
Merged
Merged
Conversation
nop33
commented
Jun 22, 2026
nop33
commented
Member
- Fix memory leak by removing event listeners on reject
- Update allowed hasher
h0ngcha0
reviewed
Jun 23, 2026
| @@ -0,0 +1,6 @@ | |||
| import { MessageHasher } from "@alephium/web3" | |||
|
|
|||
| export const SAFE_DAPP_MESSAGE_HASHER = "alephium" | |||
Member
There was a problem hiding this comment.
This would disable Nostr injection, which uses the sha256 hasher.
If it is ok to remove Nostr support, then it shouldn't be a problem.
Member
There was a problem hiding this comment.
sha256 should be okay to be kept since it's not used for tx building
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.