Skip to content

Fix address validation #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h0ngcha0 merged 1 commit into from
Dec 21, 2025
Merged

Fix address validation #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/extension/src/ui/services/addresses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import {
number,
} from "starknet"
import * as web3 from "@alephium/web3"
import * as yup from "yup"

export const normalizeAddress = (address: string) => address
Expand Down Expand Up @@ -36,7 +34,6 @@ export const formatFullAddress = (address: string) => {
return `${hex} ${parts.join(" ")}`
}

// TODO: improve address validation
export const addressSchema = yup
.string()
.trim()
Expand All @@ -46,7 +43,7 @@ export const addressSchema = yup
return ctx.createError({ message: 'Address is required' })
}

if (!/^[1-9A-HJ-NP-Za-km-z:]+$/.test(address)) {
if (!web3.isValidAddress(address)) {
return ctx.createError({ message: 'Invalid Address' })
}

Expand Down
Loading