Repository navigation
List the Windows rows in Language Selection and Windows Language (#223) - #225
Merged
Merged
Conversation
Windows containers on BC 27.5, 28.5 and 29.0 list 248 rows in both tables; the image listed 214. ICU leaves 34 cultures out of CultureInfo.GetCultures although it knows them by their Windows names with the Windows LCID (arn-CL, en-029, the Sami and Quechua cultures, ...). BcLinuxWindowsLanguages adds them, as it already did for the Chinese regional cultures (#198). BC also builds every row from ICU's culture data. The new windowslanguagerows command (Nav.Ncl.dll) and the extended windowslanguages command (Nav.Types.dll) send those reads through helpers that hold the Windows values: 49 names, two tags, the K'iche' abbreviation, and Primary CodePage 65001 on BC 27/28 for the 44 cultures with no OEM code page. BC 29 reads abbreviations off Windows from its own table, which also differs for 1158 and 1164, so that call goes through the same helper. Measured: every field of every row of both tables matches the Windows data on BC 27.5 and 29.0. Smoke codeunit 70083 guards it. Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
StefanMaron
force-pushed
the
windows-language-rows-223
branch
from
November 8, 2026 14:56
35dd2e5 to
1db7bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Windows containers on BC 27.5, 28.5 and 29.0 list 248 rows in both Language Selection and Windows Language. The image listed 214.
Cause
CultureInfo.GetCultures, although it knows them by their Windows names with the Windows LCID: arn-CL, en-029, the Sami and Quechua cultures, and others. This is the same cause as the Chinese rows in Windows Language table has no row for some Chinese language IDs (1028 on 27.5/28.5, 3076 on 29.0) #198.Change
BcLinuxWindowsLanguagesadds the 34 cultures. BC's own filter, sort and duplicate check are unchanged.windowslanguagerows(Nav.Ncl.dll): the two table providers read name, tag and Primary CodePage through helpers that hold the Windows values.windowslanguages(Nav.Types.dll) now also sends the English names inWindowsLanguageHelper(its name-to-LCID map) andAbbreviatedNamethrough those helpers.ff-Latn-NGand 2051ca-ES-valencia.QUC.WindowsLanguageNameLookup). It hasQUTfor 1158 andZZZfor Dari (1164), where Windows hasQUCandPRS. So that call goes through the same helper.Tested locally
verify-patched-il.sh: no new errors.WindowsLanguageNameLookup.https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD