Skip to content

List the Windows rows in Language Selection and Windows Language (#223) - #225

Merged
StefanMaron merged 1 commit into
masterfrom
windows-language-rows-223
Nov 8, 2026
Merged

StefanMaron merged 1 commit into
masterfrom
windows-language-rows-223

Conversation

@StefanMaron

Copy link
Copy Markdown
Collaborator

Fixes #223.

Windows containers on BC 27.5, 28.5 and 29.0 list 248 rows in both Language Selection and Windows Language. The image listed 214.

Cause

Change

  • BcLinuxWindowsLanguages adds the 34 cultures. BC's own filter, sort and duplicate check are unchanged.
  • New patcher command windowslanguagerows (Nav.Ncl.dll): the two table providers read name, tag and Primary CodePage through helpers that hold the Windows values.
  • windowslanguages (Nav.Types.dll) now also sends the English names in WindowsLanguageHelper (its name-to-LCID map) and AbbreviatedName through those helpers.
  • Values that change:
    • 49 names.
    • Two tags: 1127 ff-Latn-NG and 2051 ca-ES-valencia.
    • One abbreviation: 1158 QUC.
    • Primary CodePage 65001 on BC 27/28 for the 44 cultures that have no OEM code page. BC 29 gives 1 on Windows, as it already does here.
  • BC 29 has its own abbreviation table off Windows (WindowsLanguageNameLookup). It has QUT for 1158 and ZZZ for Dari (1164), where Windows has QUC and PRS. So that call goes through the same helper.
  • All values are Windows data: the Language Selection table posted on the issue, and corpus codeunit 92700 for Windows Language.

Tested locally

  • BC 27.5 and BC 29.0: every field of every row of both tables matches the Windows data. I checked this with corpus codeunit 92700, including its full 248-row walk, and with a generated walk of Language Selection.
  • New smoke codeunit 70083 passes on both versions.
  • verify-patched-il.sh: no new errors.
  • The patch stops the boot when a call is not where it expects. That is how the first BC 29 run found WindowsLanguageNameLookup.

https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD

Windows containers on BC 27.5, 28.5 and 29.0 list 248 rows in both
tables; the image listed 214. ICU leaves 34 cultures out of
CultureInfo.GetCultures although it knows them by their Windows names
with the Windows LCID (arn-CL, en-029, the Sami and Quechua cultures,
...). BcLinuxWindowsLanguages adds them, as it already did for the
Chinese regional cultures (#198).

BC also builds every row from ICU's culture data. The new
windowslanguagerows command (Nav.Ncl.dll) and the extended
windowslanguages command (Nav.Types.dll) send those reads through
helpers that hold the Windows values: 49 names, two tags, the K'iche'
abbreviation, and Primary CodePage 65001 on BC 27/28 for the 44
cultures with no OEM code page. BC 29 reads abbreviations off Windows
from its own table, which also differs for 1158 and 1164, so that call
goes through the same helper.

Measured: every field of every row of both tables matches the Windows
data on BC 27.5 and 29.0. Smoke codeunit 70083 guards it.

Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
@StefanMaron
StefanMaron force-pushed the windows-language-rows-223 branch from 35dd2e5 to 1db7bae Compare November 8, 2026 14:56
@StefanMaron
StefanMaron merged commit cf9d023 into master Nov 8, 2026
22 checks passed
@StefanMaron
StefanMaron deleted the windows-language-rows-223 branch November 8, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language Selection has 214 rows on Linux, 247 on Windows

1 participant