Repository navigation
Stop the boot when an app the boot publishes fails (#219) - #220
Merged
Merged
Conversation
Without libSkiaSharp every dev-endpoint publish fails, also for apps with no report. The test toolkit publish only echoed the HTTP code, so the boot wrote /tmp/bc-ready and the healthcheck passed on a tier with no Test Runner, Library Assert or Any. The keep-set install, the default toolkit publish and the Test Runner Extension publish now record failures, with the response body. If any failed, the entrypoint stops NST and the container exits with rc 1. BC_ALLOW_PUBLISH_FAILURES=1 continues instead. The SkiaSharp warning now says that publishing fails too. Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219.
Without libSkiaSharp every dev-endpoint publish failed on BC 29.0, also for apps with no report. The boot only echoed each HTTP code, wrote
/tmp/bc-ready, and the healthcheck passed on a tier with no Test Runner, Library Assert or Any.Changes
publish-app.sh.wait-for-bc-healthy.shanddocker compose up --waitthen fail right away, not after the 30-minute healthcheck.BC_ALLOW_PUBLISH_FAILURES=1finishes the boot anyway./tmp/bc-readyis removed at the start of the entrypoint, so adocker restartcannot pass the healthcheck early on the previous run's marker.Testing
Image built from this branch, local boots:
The last row is why the warning says "can fail": the reported failure is on BC 29.0 with SkiaSharp 4.152.1, and BC 27.5 with SkiaSharp 3.119.0 published fine without the native. CI covers the keep-set path on every version.
https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD