Repository navigation
Fix control add-in registration on Linux package paths - #217
Merged
StefanMaron merged 1 commit intoNov 8, 2026
Merged
Conversation
Contributor
|
Tested on BC 28.5 ( Setup: published runner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing an app with JavaScript control add-ins can return HTTP 200 without registering any controls. The web client then reports that the control is not permitted.
ReadDirectoryFilePathscomparesPath.GetDirectoryName(file).Trim('\\')withaddin; on Linux the remaining/addinnever matches.Fixes #216.
This adds a narrow Cecil patch to the package reader's directory predicate. It normalizes package/URI separators while preserving the existing comparison and leaving ordinary filesystem lookups unchanged. The same predicate serves
perm,serv,replayandprofile. The patch runs before NST loads CodeAnalysis, independently ofBC_WINDOWS_TEXT, and stops startup if the expected single lookup cannot be found. Applying it twice does not rewrite the assembly.The new AL smoke guard checks the existing fixture control's tenant registration, category and token. It is included in both branches of the BC version matrix. A separate Windows/Linux job covers 13 package-path cases, including nested resource exclusion.
Validation
Local runtime checks used BC 27.5.46862.52969 US, fresh stock artifact databases and empty service/assembly caches. The local image layered the rebuilt .NET 8 patcher and updated entrypoint on published runner digest
367941d8884b88e0cd8b5fa7eaac376cf33d2ad07bc4b6a9c45ce3bc5938eb7d.70000|70051|70080, upstream WebSocket runner: 4 total, 3 passed, 1 failed. The new registration test expected 1 and found 0; the existing add-in-not-instantiated test passed.Scripts+StartupScriptfixture: “Control add-in registered and running”, after JS → AL → JS. The callable function was moved intoScriptsbecause functions declared insideStartupScriptare scoped locally; this is a correction to the browser fixture, separate from the registration defect.bash -n, workflow YAML parsing andgit diff --checkpassed.The local AL run compiled a focused subset of smoke fixtures; it was not a full smoke-suite run. BC 28/29 runtime validation has not been performed locally; the updated version matrix is configured to run the new guard on those legs.