Repository navigation
Run test codeunits in ID order (#209) - #213
Merged
Merged
Conversation
run-tests.sh ran codeunits in the order of the app's SymbolReference.json. BC caches Execute checks per session, so the order changes what a later codeunit may open under an exact permission set. The altool runner already sorts by ID. Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209. This is not a BC 27.5 problem and not a permission difference in the tier. It comes from the order
run-tests.shruns codeunits in.Cause.
run-tests.shtook the codeunit list from the app'sSymbolReference.jsonand kept that file's order, for example 94807, 94896, 94897, 94808. It also did this to the sorted listrun-tests-hybrid.pypasses it. BC caches Execute checks per session (NavSession.verifyExecutePermissionCollection), so what an earlier codeunit did changes what a later one may do. In the failing cases,NavForm.OpenFormAsyncrefuses Execute on the page's source table, and the page aborts with "has to close".It looked specific to BC 27.5 because 27.x only has the websocket runner. BC 28+ sends these codeunits to the hub runner, and
run-tests-altool.pyalready sorted by ID.Measured with the corpus's probes (
lt-y90-perm-shapes, with the#if BC28PLUScases turned on):Y90_Open_CaptionAndGrants,Y90_Open_CodeunitStarSystemStarSetWith ID order,
Y90_Part_ExactAandY90_Part_ExactBalso pass on BC 27.5. They passed in my symbol-order run too, so I did not reproduce that part of the issue locally. It may need the corpus's full batch.What I did not establish:
No regression test. The order depends on how the compiler writes the symbol file, so a smoke test cannot force it.
Effect on consumers. Codeunits now run in a different order on the websocket runner. A corpus test that passed only because of the old order may change result. That is the same kind of difference as this issue, and ID order is the order the hub runner already uses.
https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD