Repository navigation
Let the caller choose the test runner codeunit - #200
Merged
Merged
Conversation
The websocket runner ran every suite through 130450 "Test Runner - Isol. Codeunit", hardcoded in SetupSuite. A new field TestRunnerId on table 99903 (Test Runner Extension 3.3.0.0) sets the suite's "Test Runner Id" instead; 0 keeps 130450. run-tests.sh takes --test-runner-codeunit <id>, and both reusable workflows take test_runner_codeunit_id. The hub runs tests without a runner codeunit, so with the input set bc-test-from-source.yml sends every codeunit to the websocket runner and test_runner=altool fails. The id is only sent when set, so the default run still works against an older image. Checked on BC 28.4 with a test app that has its own Subtype = TestRunner codeunit and a test that passes only when that runner's OnBeforeTestRun ran: passes with --test-runner-codeunit 70190, fails without it and with 130451. A runner id that does not exist fails the run with BC's error. Smoke codeunits 70000, 70001, 70040, 70075 with the default runner: 19 passed. Claude-Session: https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193.
What changes
TestRunnerId(Test Runner Extension 3.3.0.0).SetupSuiteandSetupSuiteAppendgive the DEFAULT suite that runner. 0 keeps 130450 "Test Runner - Isol. Codeunit", which was hardcoded before.run-tests.sh --test-runner-codeunit <id>. The id is only sent when set, so the default run still works against an older image.test_runner_codeunit_idinput onbc-test-from-source.ymlandbc-test-prebuilt.yml. The TestRunnerHub runs tests without a runner codeunit. So when the input is set,bc-test-from-source.ymlsends every codeunit to the websocket runner, andtest_runner=altoolfails with a clear error.Checked on BC 28.4, with a test app that has its own
Subtype = TestRunnercodeunit (a copy of 130450 that countsOnBeforeTestRuncalls) and a test that passes only when that runner ran:--test-runner-codeunit 70190: passes.--test-runner-codeunit 130451: fails, as expected.Not included: a CI job that runs a suite through a custom runner. It would need its own BC boot per version. I can add one if you want it guarded in CI.
The rebuilt
TestRunnerExtension.appwas compiled with AL 17 against BC 28.4 symbols, at runtime 16.0 as before. The BC 27 leg of the version matrix checks that it still publishes there.https://claude.ai/code/session_01B5GPNVNEoh5CSGzgTPEthD