Repository navigation
Make the run target follow the build the Microsoft apps come from - #8236
Draft
StefanMaron wants to merge 1 commit into
Draft
StefanMaron wants to merge 1 commit into
StefanMaron wants to merge 1 commit into
Conversation
--bc-version 29 on a 29.1 build kept minor 0, so Feature Key served the rows measured on 29.0 while --bc-version 29.1 and the full build number refused them. BcVersion::resolved_to now sets the minor from the resolved build (same major only) and both CLIs call it. Fixes #8209.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[al-runtime-rs / tooling-cli: run target follows the resolved build / DONE]
Fixes #8209
What changes
--bc-version 29kept minor 0 even when the Microsoft apps came from a 29.1 build. Feature Key then served the rows measured on 29.0, while--bc-version 29.1and the full build number refused them.BcVersion::resolved_tonow sets the target's minor from the resolved build (same major only) and records the build string. Both CLIs call it. The special case in alrunner-cli that did this only for package builds is removed.--bc-version 29on a 29.1 build--bc-version 29.1/ full build--bc-version 29on a 29.0 build (neighbor)Red/green:
al-versiontestthe_target_follows_the_build_the_microsoft_apps_come_from. Red:left: (29, 0, "29.1.57326.58275") right: (29, 1, ...). Green after the change. No 29.1 artifact is cached here, so there is no end-to-end run on 29.1.Checks:
--baseline-diffon BC 27, 28, 29: 0 regressions, 0 stale lines on every variant. Nothing pruned.Also follows the build now (named so review can check): a run without
--bc-versionwhose newest published build is a later minor; the--stabilitycell name (29.1-w1instead of29.0-w1); the Test Runner version in the call stack text when no Test Runner app is loaded.Needs probe: none. Needs CI observation: none.