Skip to content

Make the run target follow the build the Microsoft apps come from - #8236

Draft
StefanMaron wants to merge 1 commit into
mainfrom
area-tooling-cli-1117b
Draft

StefanMaron wants to merge 1 commit into
mainfrom
area-tooling-cli-1117b

Conversation

@StefanMaron

Copy link
Copy Markdown
Collaborator

[al-runtime-rs / tooling-cli: run target follows the resolved build / DONE]

Fixes #8209

What changes
--bc-version 29 kept minor 0 even when the Microsoft apps came from a 29.1 build. Feature Key then served the rows measured on 29.0, while --bc-version 29.1 and the full build number refused them. BcVersion::resolved_to now sets the target's minor from the resolved build (same major only) and records the build string. Both CLIs call it. The special case in alrunner-cli that did this only for package builds is removed.

form before after
--bc-version 29 on a 29.1 build 29.0 Feature Key rows served refused, as the other two forms (Rust test)
--bc-version 29.1 / full build refused same
--bc-version 29 on a 29.0 build (neighbor) 29.0 rows same (Rust test)
build of another major minor kept same (Rust test)

Red/green: al-version test the_target_follows_the_build_the_microsoft_apps_come_from. Red: left: (29, 0, "29.1.57326.58275") right: (29, 1, ...). Green after the change. No 29.1 artifact is cached here, so there is no end-to-end run on 29.1.

Checks: --baseline-diff on BC 27, 28, 29: 0 regressions, 0 stale lines on every variant. Nothing pruned.

Also follows the build now (named so review can check): a run without --bc-version whose newest published build is a later minor; the --stability cell name (29.1-w1 instead of 29.0-w1); the Test Runner version in the call stack text when no Test Runner app is loaded.

Needs probe: none. Needs CI observation: none.

--bc-version 29 on a 29.1 build kept minor 0, so Feature Key served the
rows measured on 29.0 while --bc-version 29.1 and the full build number
refused them. BcVersion::resolved_to now sets the minor from the
resolved build (same major only) and both CLIs call it. Fixes #8209.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--bc-version 29 and --bc-version 29.1 pick the same build but answer Feature Key differently

1 participant